Skip to content

fix(title): honor reasoning_effort so thinking can be disabled on title generation - #90064

Closed
Jeffgithub0029 wants to merge 1 commit into
NousResearch:mainfrom
Jeffgithub0029:fix/title-reasoning-effort
Closed

Jeffgithub0029 wants to merge 1 commit into
NousResearch:mainfrom
Jeffgithub0029:fix/title-reasoning-effort

Conversation

@Jeffgithub0029

Copy link
Copy Markdown

Fixes the docstring/code gap in #83390: the title call's docstring claimed thinking was disabled, but the call set neither reasoning_config nor reasoning_effort, so DeepSeek-family models ran thinking at max_tokens=64 and returned an empty content.

What:

  • agent/title_generator.py: read auxiliary.title_generation.reasoning_effort and pass a provider-agnostic reasoning_config. parse_reasoning_effort("none") → {"enabled": False}, which the DeepSeek / OpenCode Go provider profiles translate into thinking.type: disabled. When unset, the provider default stands (thinking ON for DeepSeek V4) — never force-disables for providers that don't support the field.
  • Tests for both the enabled/disabled and unset paths.

Note: this branch is a clean rebase onto current main; it supersedes the previously closed branch based on stale upstream.

Tests: tests/agent/test_title_generator.py — 38 passed locally.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint provider/deepseek DeepSeek API labels Aug 19, 2026
@Jeffgithub0029

Copy link
Copy Markdown
Author

Closing as duplicate. #85424 addresses the same root cause (title generation for reasoning models / strict local providers) more completely — it drops response_format entirely and falls back to reasoning_content, verified end-to-end. This PR's reasoning_effort carve-out overlaps that scope, so I'm deferring to #85424 to avoid duplicate-review noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have provider/deepseek DeepSeek API type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants