fix(title): honor reasoning_effort so thinking can be disabled on title generation - #90064
Closed
Jeffgithub0029 wants to merge 1 commit into
Closed
Jeffgithub0029 wants to merge 1 commit into
Jeffgithub0029 wants to merge 1 commit into
Conversation
Author
|
Closing as duplicate. #85424 addresses the same root cause (title generation for reasoning models / strict local providers) more completely — it drops |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the docstring/code gap in #83390: the title call's docstring claimed thinking was disabled, but the call set neither
reasoning_confignorreasoning_effort, so DeepSeek-family models ran thinking atmax_tokens=64and returned an emptycontent.What:
agent/title_generator.py: readauxiliary.title_generation.reasoning_effortand pass a provider-agnosticreasoning_config.parse_reasoning_effort("none")→{"enabled": False}, which the DeepSeek / OpenCode Go provider profiles translate intothinking.type: disabled. When unset, the provider default stands (thinking ON for DeepSeek V4) — never force-disables for providers that don't support the field.Note: this branch is a clean rebase onto current main; it supersedes the previously closed branch based on stale upstream.
Tests:
tests/agent/test_title_generator.py— 38 passed locally.