fix(pairing): accept spaced approval codes - #89937
Open
teknium1 wants to merge 1 commit into
Open
Conversation
Port from nanocoai/nanoclaw#3282: normalize visual whitespace in DM pairing codes while preserving exact-match rejection for chatter-wrapped input.
Contributor
૮ >ﻌ< ა ci reviewran on 127a7ab — fix(pairing): accept spaced approval codes ❌ Job failuresPython tests / Run tests slice 12/12 · View jobJob Python tests / Run tests slice 12/12 failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hermes pairing approval now accepts codes pasted with visual whitespace while still rejecting chatter-wrapped text.
Changes
gateway/pairing.py: normalize internal whitespace before matching pairing approval codes.tests/gateway/test_pairing.py: cover spaced-code acceptance and word-wrapped rejection.Source
PairingStore.approve_code()so CLI, dashboard, desktop, and gateway callers inherit it.Validation
scripts/run_tests.sh tests/gateway/test_pairing.py -qHERMES_HOMEInfographic
Skipped: FAL image generation returned
Exhausted balanceduring this cron run.