Skip to content

fix(desktop): close the blank hole in the Sessions header - #89814

Merged
OutThisLife merged 1 commit into
mainfrom
bb/session-group-icon-fix
Aug 19, 2026
Merged

OutThisLife merged 1 commit into
mainfrom
bb/session-group-icon-fix

Conversation

@OutThisLife

Copy link
Copy Markdown
Contributor

Summary

The Sessions header is justify-between. Mark-all was added as a sibling of the +/filter cluster, so with unread sessions it sat in the middle as a 24px empty slot (icon is opacity-0 until hover). One cluster now, same as Pinned/Projects.

Introduced by #76504, landed via #86772.

Test plan

  • With at least one unread session, the Sessions header should show SESSIONS flush left and the check-all / + / filter icons flush right — no empty square in the middle
  • Hover the header: check-all and + fade in next to the filter, not floating mid-row
  • Click check-all: unread dots clear
  • Enter a project: scoped header actions still sit flush right

The unread check-all was a sibling of the +/filter cluster. The header
is justify-between, so that extra child sat in the middle as a blank
24px hole until hover.
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Aug 19, 2026
@OutThisLife
OutThisLife merged commit 70e818c into main Aug 19, 2026
10 checks passed
@OutThisLife
OutThisLife deleted the bb/session-group-icon-fix branch August 19, 2026 07:49
bobaba76 pushed a commit to bobaba76/hermes-agent that referenced this pull request Aug 27, 2026
…oup-icon-fix

fix(desktop): close the blank hole in the Sessions header
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…oup-icon-fix

fix(desktop): close the blank hole in the Sessions header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants