Skip to content

Drop the dev-only tour demo - #89798

Merged
OutThisLife merged 1 commit into
mainfrom
bb/tour-demo-remove
Aug 19, 2026
Merged

Drop the dev-only tour demo#89798
OutThisLife merged 1 commit into
mainfrom
bb/tour-demo-remove

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Summary

The tour demo was scaffolding for building #89620 — a way to look at the tour UI without spending an agent turn on every iteration. That work is merged, so the demo has outlived its purpose and shouldn't have ridden along with it.

It was DEV-gated and dynamically imported, so it never reached a production build, but it still added a floating button, a Ctrl+Shift+X hotkey, a palette row and a window.__tourDemo() hook to every dev session.

Removing it also restores the credit-notice demo's original single-disposer wiring, and drops the Compass icon export the demo was the only consumer of. The tour feature itself is untouched.

Test plan

  • tsc --noEmit clean
  • 18 tour engine tests green — the feature is unaffected
  • No remaining references to tour-demo, installTourDemo, __tourDemo, or Compass

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on ff8c415 — chore(desktop): drop the dev-only tour demo

⚠️ Warnings

OSV vulnerability scan · View job

7 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.


debug info

CI timings

CI timings · View report · View job

Wall time 5m40s vs 8m55s (-36.4%). 10 job(s) slower, 8 faster, 1 unchanged.

  • JS & TS checks / apps/desktop / check:test:ui:shard-1of3: +21.0s
  • JS & TS checks / apps/desktop / check:test:ui:shard-3of3: -16.0s
  • JS & TS checks / ui-tui / check: +15.0s
  • JS & TS checks / apps/desktop / check:test:desktop:all: +11.0s
  • JS & TS checks / apps/bootstrap-installer / check: +11.0s

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Aug 19, 2026
The demo existed to iterate on the tour UI without spending an agent turn per
look. That work is done and merged, so it is scaffolding now — a floating
button, a hotkey, a palette row and a window hook, none of which anyone needs
again.

Removing it restores the credit-notice demo's original single-disposer wiring
and drops the Compass icon export, which the demo was the only consumer of.
The tour feature itself is untouched.
@OutThisLife
OutThisLife enabled auto-merge August 19, 2026 06:25
@OutThisLife
OutThisLife merged commit 38f79e2 into main Aug 19, 2026
41 checks passed
@OutThisLife
OutThisLife deleted the bb/tour-demo-remove branch August 19, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants