fix(bot-mode): Routines pane scopes to the clicked bot, not the stale gateway profile

[chelsealong]

Fixes #89625

Bug

In Bot Mode, clicking a different bot in the roster doesn't change which
bot's cron jobs the Routines pane shows — it keeps showing the previously
active bot's jobs (e.g. the default profile's 14 jobs instead of Blog
Writer's 1) until a chat message is sent, and sometimes not even then.

Root cause

RoutinesPane (apps/desktop/src/plugins/hermes-bots/plugin.js) picked
gatewayProfile (host.state.profile, the profile the chat connection is
currently routed through) ahead of $selectedBot (the bot the user just
clicked):

const bot = (gatewayProfile || selected || 'default').trim() || 'default'

Clicking a bot in the roster sets $selectedBot synchronously, but the
gateway connection takes a moment to actually swap over — host.state.profile
still reports the previous bot during that window. Since the old code
preferred gatewayProfile, the pane queried cron.manage with the wrong
profile scope until the connection caught up (and could stay wrong if the
routing never fully switched, per the report).

Fix

Flip the precedence and extract the decision into a small pure helper:

function resolveRoutinesBot(selected, gatewayProfile) {
  return (selected || gatewayProfile || 'default').trim() || 'default'
}

RoutinesPane now calls resolveRoutinesBot(selected, gatewayProfile).

Making $selectedBot win unconditionally is only safe if $selectedBot is
actually always current — and a first version of this fix (reviewed here)
wasn't: the host.state.profile.listen(...) subscriber that keeps
$selectedBot synced to the live gateway profile is attached in register()
and torn down in onDispose(). nanostores' .listen() never replays the
current value the way .subscribe() does, so if a user disables Bot Mode,
switches the active gateway profile while it's disabled, then re-enables it,
$selectedBot stayed pointed at the pre-disable bot until the next profile
change happened to fire the listener — which, combined with the precedence
flip, would have made RoutinesPane show the wrong bot's jobs indefinitely
(the same failure class as the original bug, just moved to a longer-lived
trigger).

Fixed by extracting the sync into bindProfileSync(), which reseeds
$selectedBot from the profile store's current value before attaching the
listener:

function bindProfileSync(profileStore) {
  const current = profileStore.get?.()
  if (current && typeof current === 'string') {
    $selectedBot.set(current)
  }
  return profileStore.listen(profile => {
    if (profile && typeof profile === 'string') {
      $selectedBot.set(profile)
    }
  })
}

register() now calls bindProfileSync(host.state.profile), so every
register — including a disable → re-enable cycle — starts back in sync with
the live profile before anything can rely on $selectedBot.

Test

apps/desktop/src/plugins/hermes-bots/tests/routines-selected-bot.test.mjs
(following this suite's existing vm-harness pattern, see
routines-error.test.mjs) covers both the pure resolveRoutinesBot helper
and, separately, bindProfileSync's reseed behavior — using a fake profile
store that mirrors real nanostores get/listen semantics (listen does
not replay the current value) rather than a mock that assumes the fix works.
The new regression test drives: bind (reseed to "blog-writer") → unbind
(disable) → profile changes to "researcher" while unbound → bind again
(re-enable) → asserts $selectedBot and resolveRoutinesBot both resolve to
the live "researcher" profile, not the stale "blog-writer".

Verified the new regression tests fail without the bindProfileSync reseed
(reverting just the reseed lines, keeping the plain .listen()):

not ok - regression: re-enabling after a profile switch while disabled resyncs, not stays stale
  expected: 'blog-writer'
  actual: 'default'

And that all tests in the file fail against the pre-fix commit, where
bindProfileSync doesn't exist at all:

$ git checkout HEAD~1 -- apps/desktop/src/plugins/hermes-bots/plugin.js
$ node --test apps/desktop/src/plugins/hermes-bots/tests/routines-selected-bot.test.mjs
error: 'bindProfileSync is not defined'
# pass 0
# fail 5

All pass with the fix in place:

$ node --test apps/desktop/src/plugins/hermes-bots/tests/routines-selected-bot.test.mjs
# tests 5
# pass 5
# fail 0

Full plugin test suite (from apps/desktop):

$ npm run check:test:plugins
# tests 288
# pass 288
# fail 0

AI assistance disclosure

This change was authored with AI assistance (Claude).

[teknium1]

Merged via PR #89717 (#89717) with your authorship preserved. Note: the precedence-flip half was superseded on main by 23c1c98 shortly before you opened this, but your second finding — the missing get()-before-listen reseed of the selected bot — was real and unfixed; that half is what landed, with your regression tests adapted to the new $focusedBotProfile design. Thanks for the sharp diagnosis!