Bugfix: ignore legacy compression model for auto providers - #8955
Closed
HiddenPuppy wants to merge 1 commit into
Closed
Bugfix: ignore legacy compression model for auto providers#8955HiddenPuppy wants to merge 1 commit into
HiddenPuppy wants to merge 1 commit into
Conversation
Contributor
|
Addressed in #8992 which took this further — instead of patching around the legacy Thanks @HiddenPuppy for identifying the bug and the clear root cause analysis in #8923 — that directly informed the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compression.summary_modelwhencompression.summary_provideris stillautoContextCompressor, so auto-routed compression summaries use a provider-compatible default modelRoot Cause
The legacy compression section allowed a provider-specific model like
google/gemini-3-flash-previewto remain configured while the provider stayed onauto. That value could be threaded into compression summary calls even when the resolved backend was not OpenRouter-compatible.Validation
pytest -n 0 tests/agent/test_auxiliary_client.py::TestTaskSpecificOverrides::test_task_without_override_uses_auto tests/agent/test_auxiliary_client.py::TestTaskSpecificOverrides::test_legacy_compression_model_ignored_when_provider_is_auto tests/agent/test_auxiliary_client.py::TestTaskSpecificOverrides::test_legacy_compression_model_preserved_for_pinned_provider tests/agent/test_auxiliary_client.py::TestTaskSpecificOverrides::test_explicit_compression_pin_still_wins_over_live_main_runtime tests/agent/test_auxiliary_client.py::TestTaskSpecificOverrides::test_compression_summary_base_url_from_config tests/run_agent/test_run_agent.py::TestInit::test_legacy_auto_compression_model_not_passed_to_context_compressorpytest -n 0 tests/agent/test_context_compressor.pypytest -n 0 tests/run_agent/test_413_compression.pyCloses #8923