feat(desktop): ⌘⇧E collapses / expands all sidebar projects

[leighton-tidwell]

What

Binds the sidebar's Collapse all / Expand all to ⌘⇧E (Ctrl+Shift+E off macOS), and surfaces the hint on the menu row that already runs it.

Today that action is mouse-only: open the filter menu, then click the row. With more projects than fit on screen it's the action you reach for most often and the slowest one to get to.

The chord

⌘⇧E is the explorer mnemonic — VS Code's ⌘⇧E focuses the explorer tree — and it was unclaimed in KEYBIND_ACTIONS. A test asserts nothing else ships the same default, since a duplicate would read as a permanent conflict in the keybinds panel and make one of the two actions unreachable.

It's a normal rebindable action: it appears in the shortcuts panel under View, and the menu hint reads from useKeybindHint so a rebind is reflected there rather than hardcoding ⌘⇧E.

Shape

The toggle moves into toggleAllProjectsCollapsed in the projects store, so the menu row and the hotkey run the same code instead of drifting. It keeps every rule the menu already had:

• only the project rows fold — sweeping Pinned and Cron shut alongside them is not what "collapse all" means here;
• the lanes underneath keep their own state, so re-opening a project shows it as you left it;
• it's a no-op under a grouping that puts no project rows on screen, so the key can't write state you can't see.

No new core tool, no new env var, no new config surface — one row in the existing keybind registry, one handler, one shared store function.

Proof

Real running desktop (npm run dev, driven over CDP), not a mock.

The menu row with its live hint:

Before ⌘⇧E / after ⌘⇧E — and pressing it again restored the expanded state:

Expanded	After ⌘⇧E

Tests

Behavior contracts, not snapshots — store/projects.test.ts covers collapse, expand-back, nested lanes surviving the fold, and the non-project-grouping no-op; lib/keybinds/actions.test.ts covers registration, the English label, and the no-collision invariant.

npx vitest run                 # 629 files, 6264 passed | 2 skipped
npx tsc -p . --noEmit          # clean
npx eslint <changed files>     # clean

Related open PRs

I checked for duplicates before opening this: no issue requests it, and no PR (open, merged, or closed) implements a collapse/expand shortcut. Three open PRs touch filter-menu.tsx, none overlapping in purpose — #86196 (saved sidebar views) and #88123 (manual session ordering) are independent.

One merge-order note: #85952 (i18n for the filter menu) edits the same line this PR does, swapping the literals for f.expandAll / f.collapseAll. The changes are complementary — that PR localizes the label, this one appends a shortcut hint beside it — but whichever merges second takes a one-line conflict. Resolution is to keep their localized label AND the <DropdownMenuShortcut> sibling:

{projectsCollapsed ? f.expandAll : f.collapseAll}
{collapseHint && <DropdownMenuShortcut>{collapseHint}</DropdownMenuShortcut>}

Happy to rebase onto whichever lands first.

AI was used for the purposes of this PR

[Enough1122]

AI code review — automated review for reference; please use your judgment.

No blocking issues found.

• nit: the menu row still renders hardcoded 'Expand all' : 'Collapse all' literals while the shortcut hint is keybind-driven — already flagged by the author as the fix(desktop): localize sidebar filter menu strings (i18n) #85952 (filter-menu i18n) merge-order conflict; resolution described there looks right.
• nit: view.toggleProjects gets an English label in en.ts only; confirm missing keys fall back to en in other locales so the shortcuts panel doesn't render a raw id.
• Behavior contracts in both test files are the right shape (collapse/expand round-trip, lane state preservation, grouping no-op, chord-collision invariant) — no snapshot or source-reading antipatterns.

[leighton-tidwell]

AI was used to generate the below response and fixes that corresponds

Rebased onto current main (057dcdf23). The conflict is resolved and the PR is mergeable again. Both review nits are addressed below.

Valid, fixed — view.toggleProjects had no label outside en (dabd151c5)

This one was a real bug, so I checked it rather than assuming the fallback covered it.

keybind-settings.tsx:203 resolves labels with k.actions[action.id] ?? action.label ?? action.id, and keybinds.actions is typed Record<string, string> (i18n/types.ts:306), so a missing key is invisible to tsc. The view.toggleProjects entry carries no label of its own (keybinds/actions.ts:138), so the raw id is the last rung. ar.ts, ja.ts and zh-hant.ts are built with defineLocale, which merges overrides over en (define-locale.ts:39), so they inherited the English string. zh.ts is a full Translations literal and inherited nothing.

Enumerating TRANSLATIONS at runtime confirmed it:

en       -> Collapse / expand all projects
zh       -> *** UNDEFINED (renders raw id) ***
zh-hant  -> Collapse / expand all projects
ja       -> Collapse / expand all projects
ar       -> Collapse / expand all projects

Chinese users would have seen the literal string view.toggleProjects in the shortcuts panel. Added the zh label, plus a contract test asserting every shipped locale resolves the key to real text rather than the action id. Removing the zh line again fails it with zh is missing a view.toggleProjects label, so it covers the next locale too.

Design decision — deferring the hardcoded label to the author

The 'Expand all' : 'Collapse all' literals at filter-menu.tsx:403 are unchanged. That line belongs to #85952's i18n pass, and merge order between these two PRs is the author's call, not something to settle here. The rebase left the resolution exactly as described in the PR description: localized label plus the <DropdownMenuShortcut> sibling.

Verification (worktree on 057dcdf23 + these two commits)

npx vitest run          # 710 files, 7375 passed | 3 skipped
npx tsc -p . --noEmit   # clean
npx eslint <8 changed files>   # clean