Skip to content

fix(desktop): let Files panel download remote backend files - #89257

Merged
OutThisLife merged 2 commits into
NousResearch:mainfrom
xxxigm:fix/desktop-files-panel-remote-download
Aug 19, 2026
Merged

fix(desktop): let Files panel download remote backend files#89257
OutThisLife merged 2 commits into
NousResearch:mainfrom
xxxigm:fix/desktop-files-panel-remote-download

Conversation

@xxxigm

@xxxigm xxxigm commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • On a remote gateway, the Desktop Files panel only offered Copy Path / Copy Relative Path. Those are server paths, so they do not put the file on the local machine.
  • Add a Download action for files (not folders) in remote mode, using the existing authenticated gateway save bridge (saveGatewayFile / /api/fs/download).
  • Local Reveal / Rename / Delete stay hidden in remote mode; copy-path still works.

Test plan

  • npm run test --workspace apps/desktop -- src/store/file-actions.test.ts src/app/right-sidebar/review/file-tree.test.tsx
  • Connect Desktop (Windows) to a Linux remote gateway, right-click a file in the Files panel, choose Download, and confirm the save dialog writes it locally
  • Cancel the save dialog — no toast, no local file
  • Right-click a folder in remote mode — Download is absent
  • Local (non-remote) Files panel still shows Reveal / Rename / Delete and no Download

xxxigm added 2 commits August 18, 2026 22:19
Remote mode only offered Copy Path, which is a Linux server path and useless on the local machine. Reuse the existing gateway save bridge so a selected file can land on this computer.
Lock the remote-file-only menu gate and the save-bridge success, cancel, and error paths.
@alt-glitch alt-glitch added type/feature New feature or request comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Aug 18, 2026

@OutThisLife OutThisLife left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Download for remote Files panel files is the right fix, and it reuses the existing gateway save bridge. Thanks @xxxigm.

@OutThisLife
OutThisLife merged commit b82f8b0 into NousResearch:main Aug 19, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants