fix(desktop): authenticate gated file downloads for password remotes - #89013
Closed
686f6c61 wants to merge 2 commits into
Closed
fix(desktop): authenticate gated file downloads for password remotes#89013686f6c61 wants to merge 2 commits into
686f6c61 wants to merge 2 commits into
Conversation
auth_required maps to oauth mode, so save/read used the OAuth cookie partition. Password-only gateways store the session cookie in the default jar, and native login uses a bearer. Try the native bearer, the OAuth partition, then the default session.
gatewayWsUrlIpcResult must precede isGatewayAuthRejection.
16 tasks
Collaborator
|
Superseded by #90546. That salvage keeps the auth fix (gated downloads have to present credentials), rebased onto current main, and:
You're credited via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A remote gateway with
auth_required: trueis classified asoauth. File save/read then used only the OAuth session partition (persist:hermes-remote-oauth). Password-only (dashboard.basic_auth) logins set the session cookie viaPOST /auth/password-login, often in the default session — so/api/fs/downloadand/api/fs/read-data-url401'd while a browser cookie request succeeded. Native bearer login had the same hole on the streaming download path.Gated downloads and cookie REST now: prefer the native bearer, then the OAuth partition, then (password-only) the default session.
Related Issue
Fixes #88987
Type of Change
Changes Made
native-auth-decisions.ts:gatedCookieSessionOrder()main.ts:downloadGatedToFile/fetchJsonViaGatedCookiesused bysaveGatewayFile,hermes:api, andfetchJsonForBackendNot runtime-tested against a live password-gated remote.
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A (no UI change)