fix(backup): skip Chrome caches and bound stalled snapshots - #88853
Closed
roycepersonalassistant wants to merge 1 commit into
Closed
roycepersonalassistant wants to merge 1 commit into
roycepersonalassistant wants to merge 1 commit into
Conversation
|
This replacement PR is fully reconciled with current-main backup behavior and supersedes closed PR #72966. Focused backup suites passed (61 passed, 1 skipped), with Ruff and diff checks clean. All visible PR checks are complete with zero failures and GitHub reports the branch mergeable. The separate CI workflow record failed before creating any jobs and requires an upstream maintainer/admin rerun; this fork account cannot rerun it. Ready for maintainer review and merge. |
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current-main reconciliation
Current main now includes
076b8a5aa(fix(backup): bound locked database snapshot waits), which resolves the basic busy/locked timeout independently. This replacement retains that implementation and narrows the remaining contribution to two still-distinct cases: a repeatedSQLITE_OKcallback with no reduction in remaining pages, and locked regenerable Chrome cache databases that should not be archived at all.Supersedes #72966 because GitHub stopped associating that PR with updates to its existing fork branch even though the branch ref changed successfully.
Validation
scripts/run_tests.sh tests/hermes_cli/test_backup_stability.py tests/hermes_cli/test_backup.py -q— 61 passed, 1 skippedruff check hermes_cli/backup.py tests/hermes_cli/test_backup_stability.py— passedgit diff --check origin/main..HEAD— passedNo schema, migration, dependency, configuration, or installed-runtime change is required.