Skip to content

fix(backup): skip Chrome caches and bound stalled snapshots - #88853

Closed
roycepersonalassistant wants to merge 1 commit into
NousResearch:mainfrom
roycepersonalassistant:fix/bounded-pre-update-db-backups-v2
Closed

roycepersonalassistant wants to merge 1 commit into
NousResearch:mainfrom
roycepersonalassistant:fix/bounded-pre-update-db-backups-v2

Conversation

@roycepersonalassistant

Copy link
Copy Markdown
Contributor

Summary

  • preserve the current-main bounded SQLite backup behavior while also timing out callbacks that report no page-count progress
  • skip regenerable Chrome CDP cache subtrees without dropping durable browser profile state such as cookies and logins
  • keep full, automatic, and pre-update backup traversal aligned
  • add focused coverage for locked databases, non-advancing callbacks, Chrome cache exclusion, and profile-state preservation

Current-main reconciliation

Current main now includes 076b8a5aa (fix(backup): bound locked database snapshot waits), which resolves the basic busy/locked timeout independently. This replacement retains that implementation and narrows the remaining contribution to two still-distinct cases: a repeated SQLITE_OK callback with no reduction in remaining pages, and locked regenerable Chrome cache databases that should not be archived at all.

Supersedes #72966 because GitHub stopped associating that PR with updates to its existing fork branch even though the branch ref changed successfully.

Validation

  • scripts/run_tests.sh tests/hermes_cli/test_backup_stability.py tests/hermes_cli/test_backup.py -q — 61 passed, 1 skipped
  • ruff check hermes_cli/backup.py tests/hermes_cli/test_backup_stability.py — passed
  • git diff --check origin/main..HEAD — passed

No schema, migration, dependency, configuration, or installed-runtime change is required.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard tool/browser Browser automation (CDP, Playwright) area/install-update Installer, updater, packaging, wheels, doctor sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 18, 2026

Copy link
Copy Markdown

This replacement PR is fully reconciled with current-main backup behavior and supersedes closed PR #72966. Focused backup suites passed (61 passed, 1 skipped), with Ruff and diff checks clean. All visible PR checks are complete with zero failures and GitHub reports the branch mergeable. The separate CI workflow record failed before creating any jobs and requires an upstream maintainer/admin rerun; this fork account cannot rerun it. Ready for maintainer review and merge.

Copy link
Copy Markdown

@teknium1 Maintainer handoff: this replacement for closed #72966 is reconciled with current-main backup behavior, locally validated, conflict-free, and has zero failed visible checks. Please approve/rerun the empty-job CI workflow record and merge when satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install-update Installer, updater, packaging, wheels, doctor comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/browser Browser automation (CDP, Playwright) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants