fix(kanban): keep initially blocked tasks sticky - #88686
Open
javiersangsanchez-droid wants to merge 1 commit into
Open
fix(kanban): keep initially blocked tasks sticky#88686javiersangsanchez-droid wants to merge 1 commit into
javiersangsanchez-droid wants to merge 1 commit into
Conversation
Collaborator
Duplicate of #64830. Both patches treat the created-event payload with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_task(initial_status="blocked")as an explicit sticky holdunblock_taskstill releases the taskRoot cause
recompute_ready()only recognizedblockedevents as sticky. Initially blocked tasks emit acreatedevent whose payload recordsstatus: blocked, so the dispatcher misclassified them as circuit-breaker recoveries and promoted them automatically.Tests
scripts/run_tests.sh tests/hermes_cli/test_kanban_blocked_sticky.py tests/hermes_cli/test_kanban_db.py -q(33 passed, 1 skipped)ruff check hermes_cli/kanban_db.py tests/hermes_cli/test_kanban_blocked_sticky.pyFixes #78933
Fixes #71847
Fixes #47777
Fixes #39609