fix(docker): add profiles directory and honor HERMES_HOME env override in entrypoint - #8862
Closed
luyao618 wants to merge 1 commit into
Closed
fix(docker): add profiles directory and honor HERMES_HOME env override in entrypoint#8862luyao618 wants to merge 1 commit into
luyao618 wants to merge 1 commit into
Conversation
…e in entrypoint
The Docker entrypoint hardcoded HERMES_HOME="/opt/data", silently
overriding any user-supplied -e HERMES_HOME=/custom value. Also the
mkdir -p list was missing the profiles directory needed for multi-profile
deployments.
- Use ${HERMES_HOME:-/opt/data} to respect user overrides while keeping
the default
- Export HERMES_HOME so it survives the gosu re-exec and reaches the
final exec hermes process
- Add profiles to the bootstrapped directory list
luyao618
force-pushed
the
fix/docker-volume-profiles-hermes-home
branch
from
April 24, 2026 17:05
4f06447 to
78488bb
Compare
Collaborator
|
Related to #8115 (also open, same HERMES_HOME env override fix). This PR also adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Docker
entrypoint.shhardcodedHERMES_HOME="/opt/data", silently overriding any user-supplied-e HERMES_HOME=/customvalue. Users who wanted to customize the data directory location (e.g.docker run -e HERMES_HOME=/custom/path -v /host/path:/custom/path) had their override ignored. Additionally, themkdir -pbootstrap list was missing theprofilesdirectory, which is required for multi-profile deployments (hermes profile create).PR #6936 previously addressed missing directories (skins/plans/workspace) but the maintainer explicitly noted "Left HERMES_HOME hardcoded for now". This PR completes the remaining fix.
Related Issue
Fixes #6877
Type of Change
Changes Made
docker/entrypoint.sh:HERMES_HOME="/opt/data"withHERMES_HOME="${HERMES_HOME:-/opt/data}"to honor user-supplied env var while keeping the defaultexport HERMES_HOMEso the variable survives thegosure-exec (line 29) and reaches the finalexec hermesprocess (line 64)profilesto themkdir -pdirectory bootstrap listHow to Test
Default behavior (backward compatible):
Custom HERMES_HOME:
Profiles directory created:
docker run nousresearch/hermes-agent ls -d /opt/data/profiles # Should exist without errorChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A