Skip to content

fix(telegram): bound fallback connection pools - #88505

Open
fmercurio wants to merge 1 commit into
NousResearch:mainfrom
fmercurio:fix/telegram-connection-budget
Open

fmercurio wants to merge 1 commit into
NousResearch:mainfrom
fmercurio:fix/telegram-connection-budget

Conversation

@fmercurio

Copy link
Copy Markdown

Summary

  • cap Telegram fallback IPv4 targets so lazy fallback-pool fan-out is finite
  • distribute the configured connection and keepalive budget across both PTB clients and every primary/fallback pool
  • make direct transport defaults transport-wide rather than per-IP pool budgets
  • preserve explicit caller limits and existing fallback cleanup/CLOSE_WAIT protections

Validation

  • focused Telegram network, fallback-pool-release, and CLOSE_WAIT tests: 36 passed
  • compileall on touched Telegram modules: passed
  • git diff --check: passed
  • independent review: no blockers (base 4323c67; reviewed patch SHA-256 ad521d60e3ee5db978dc8148eeae7ffb5c2f8abe7ca5931c06b2bee1f9245884)

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages duplicate This issue or pull request already exists labels Aug 17, 2026
@alt-glitch

Copy link
Copy Markdown

This was generated by AI during triage.

Duplicate of #82860 — the live diffs implement the same fallback-pool cap and per-pool budget derivation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants