fix(profiles): seed plugins/ for new profiles - #88153
Open
liuhao1024 wants to merge 1 commit into
Open
Conversation
hermes profile create seeded skills/, memories/, sessions/ and friends but not plugins/. Plugin discovery resolves user plugins under $HERMES_HOME/plugins/, so for a profile created without the directory a model-provider plugin configured in the profile's config.yaml failed with "Unknown provider" - the provider was simply invisible to any non-default profile (NousResearch#88143).
9 tasks
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
hermes profile createseed theplugins/directory for new profiles._PROFILE_DIRSseededskills/,memories/,sessions/,skins/,logs/,plans/,workspace/,cron/, andhome/— but notplugins/. Plugin discovery resolves user plugins under$HERMES_HOME/plugins/, and a profile activation swapsHERMES_HOMEto the profile directory, so for any profile created byhermes profile createthe discovery path was simply absent: a model-provider plugin configured in the profile'sconfig.yamlfailed withUnknown provider 'myprovider'even though the same provider worked on the default profile (#88143).The fix adds
"plugins"to_PROFILE_DIRS(one line plus a comment documenting the discovery dependency). Cloned profiles were already covered —--clonecopies the whole tree, and #69913 adds explicitplugins/clone handling — this closes the fresh-create gap.Related Issue
Fixes #88143
Type of Change
Changes Made
hermes_cli/profiles.py—_PROFILE_DIRSgains"plugins"with a comment naming_user_plugins_dir()discovery and the failure mode.tests/hermes_cli/test_profiles.py—TestCreateProfilegainstest_seeds_plugins_dir: a fresh profile containsplugins/, so the discovery path exists end-to-end for model-provider plugins.How to Test
python -m pytest tests/hermes_cli/test_profiles.py -qhermes_cli/profiles.pyhunk stashed,test_seeds_plugins_dirFAILS (plugins/absent from the fresh profile).hermes profile create architect, activate it —plugins/now exists under the profile home and the configured provider resolves.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs