fix(tools-config): stop reconfigure flow clobbering image_gen.use_gateway on managed FAL rows - #87562
Merged
Merged
Conversation
…eway on managed FAL rows
The Nous Subscription image_gen row carries imagegen_backend="fal", so
_reconfigure_provider's post-model-picker step ran
img_cfg["use_gateway"] = False
unconditionally at two sites, immediately after the managed branch had
written use_gateway=True. A user who picked Nous Subscription and then
re-entered `hermes tools` to change the model was silently flipped onto
their personal FAL_KEY.
Same bug class as fe63353, which fixed the plugin-provider selector
but missed these two legacy-backend sites in the reconfigure flow. Both
now write bool(managed_feature), matching the existing correct site in
_configure_provider.
Adds regression tests driven through the real TOOL_CATEGORIES managed
row; sabotage-verified (tests fail with the old behavior restored).
Contributor
૮ >ﻌ< ა ci reviewran on 1e59dbd — fix(tools-config): stop reconfigure flow clobbering image_ge
|
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nous-managed FAL image-gen picks now survive the model-picker step in the reconfigure flow — previously
_reconfigure_providerclobberedimage_gen.use_gatewayback toFalseright after the managed branch wroteTrue, silently routing every generation to the user's personal FAL_KEY instead of the Nous subscription.Root cause: the "Nous Subscription" image_gen row carries
imagegen_backend: "fal", and the legacy-backend model-pick step wroteuse_gateway = Falseunconditionally at two sites. Same class as fe63353, which fixed the plugin-provider selector but missed the reconfigure flow.Changes
hermes_cli/tools_config.py: both_reconfigure_providersites now writebool(managed_feature)instead of hardcodedFalse(matches the existing correct site in_configure_provider)tests/hermes_cli/test_imagegen_managed_gateway.py: 2 regression tests driven through the realTOOL_CATEGORIESmanaged row + a direct-key rowValidation
use_gateway: false(personal key billed, drained to lockout)use_gateway: true(subscription billed)use_gateway: falseuse_gateway: false(unchanged)tests/hermes_cli/test_imagegen_managed_gateway.py+test_tools_config.pyLive-verified: repaired config generates through the gateway (Nous-billed) successfully.
Infographic