fix(discord): add auto-thread fallback path - #8692
Closed
sgaofen wants to merge 1 commit into
Closed
Conversation
sgaofen
marked this pull request as ready for review
April 13, 2026 00:51
Contributor
|
Your commit ( The seed-message-then-create-thread fallback pattern was exactly right — handles the case where Discord rejects direct |
This was referenced Aug 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message.create_thread(...)is rejectedRoot Cause
Discord's manual
/threadflow already had a fallback path when direct thread creation was rejected, but the automatic mention-triggered thread path only triedmessage.create_thread(...)once and gave up. That left some channels able to thread the first mention but silently fail later mentions when Discord rejected the direct path.Addresses #8487.
Testing
python3 -m py_compile gateway/platforms/discord.py tests/gateway/test_discord_slash_commands.pyuv run --directory /Users/stephenyu/Documents/hermes-agent-wt-8487 --extra dev pytest -o addopts='' tests/gateway/test_discord_slash_commands.py -qPlatform Tested
Contribution Guide Notes
CONTRIBUTING.mdand checked for existing open PRs before submitting this scoped bug fix.pytest tests/ -qpass unless explicitly noted.