Conversation
sgaofen
marked this pull request as ready for review
April 13, 2026 00:53
|
Likely duplicate of #8420 — both guard post-setup chat launch in non-interactive stdin environments. |
Collaborator
|
Closing as stale — the code path this addresses no longer exists on Triage notes (high confidence): If this PR's intent is still relevant against the current code, please rebase or open a fresh PR. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes chathandoff behind an interactive-stdin checkexecvpfast path for interactive terminalsFixes #8641.
Testing
python3 -m py_compile /Users/stephenyu/Documents/hermes-agent-wt-8641/hermes_cli/setup.py /Users/stephenyu/Documents/hermes-agent-wt-8641/tests/hermes_cli/test_setup.pyuv run --directory /Users/stephenyu/Documents/hermes-agent-wt-8641 --extra dev pytest -o addopts= /Users/stephenyu/Documents/hermes-agent-wt-8641/tests/hermes_cli/test_setup.py -k 'offer_launch_chat'Platform Tested
Contribution Guide Notes
CONTRIBUTING.mdand checked for existing open PRs before submitting this scoped change.pytest tests/ -qpass unless explicitly noted.