Skip to content

fix(setup): skip auto-launch without interactive stdin - #8668

Closed
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/setup-non-tty-launch-guard
Closed

sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/setup-non-tty-launch-guard

Conversation

@sgaofen

@sgaofen sgaofen commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • guard the post-setup hermes chat handoff behind an interactive-stdin check
  • keep the existing execvp fast path for interactive terminals
  • add regression coverage for the new non-interactive fallback and preserve the existing interactive launch test

Fixes #8641.

Testing

  • python3 -m py_compile /Users/stephenyu/Documents/hermes-agent-wt-8641/hermes_cli/setup.py /Users/stephenyu/Documents/hermes-agent-wt-8641/tests/hermes_cli/test_setup.py
  • uv run --directory /Users/stephenyu/Documents/hermes-agent-wt-8641 --extra dev pytest -o addopts= /Users/stephenyu/Documents/hermes-agent-wt-8641/tests/hermes_cli/test_setup.py -k 'offer_launch_chat'

Platform Tested

  • macOS 15.x (Apple Silicon)

Contribution Guide Notes

  • Reviewed CONTRIBUTING.md and checked for existing open PRs before submitting this scoped change.
  • Ran the targeted verification commands listed above for this PR. I have not claimed a full repo-wide pytest tests/ -q pass unless explicitly noted.

@sgaofen
sgaofen marked this pull request as ready for review April 13, 2026 00:53
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists labels Apr 28, 2026
@alt-glitch

Copy link
Copy Markdown

Likely duplicate of #8420 — both guard post-setup chat launch in non-interactive stdin environments.

@teknium1

Copy link
Copy Markdown
Collaborator

Closing as stale — the code path this addresses no longer exists on main.

Triage notes (high confidence):
Commit 256bedb (#25067 'fix(setup): drop post-setup chat handoff') removed _offer_launch_chat entirely from hermes_cli/setup.py; the function the PR patches no longer exists on main.

If this PR's intent is still relevant against the current code, please rebase or open a fresh PR.

(Bulk-closed during a CLI PR triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.py: hermes chat fails to launch after setup in non-TTY environments

3 participants