feat(desktop): show profile ownership in all-profile recents - #86259
Open
wevial wants to merge 1 commit into
Open
feat(desktop): show profile ownership in all-profile recents#86259wevial wants to merge 1 commit into
wevial wants to merge 1 commit into
Conversation
wevial
force-pushed
the
fix/flat-recents-profile-tags
branch
from
August 14, 2026 18:28
1c790ce to
6703b0a
Compare
Contributor
feat(desktop): show profile ownership in all-profile recents No blocking issues found. A few minor observations:
|
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shows the existing owning-profile identity glyph on ordinary recent-session rows when Hermes Desktop is displaying a flat All Profiles list.
Pinned sessions and search results already surface profile ownership in this view, but ordinary recents did not. That makes same-titled sessions—especially Bot Mode's canonical
Bot Chatsessions—indistinguishable without opening them.The implementation reuses the existing accessible
ProfileTag/ProfileGlyphpath and adds a small policy helper. It shows named-profile glyphs only when profile ownership is otherwise absent: flat All Profiles recents. Profile-grouped and scoped/single-profile views remain unchanged, as do pinned/search behavior, session titles, persistence, and routing.Related Issue
Fixes #86258
Related: #66003 / #66449 introduced the same ownership treatment for pinned sessions and search results.
Type of Change
Changes Made
apps/desktop/src/app/chat/sidebar/recents-profile-tags.tsapps/desktop/src/app/chat/sidebar/recents-profile-tags.test.tsapps/desktop/src/app/chat/sidebar/index.tsxapps/desktop/src/app/chat/sidebar/session-row.tsxapps/desktop/src/app/chat/sidebar/sessions-section.tsxHow to Test
Profile: <name>.Automated validation:
Native validation used an isolated Electron instance on macOS, leaving the installed Hermes app untouched. It confirmed profile glyphs in flat All Profiles recents and suppression under Profile grouping.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass — N/A; this is a Desktop renderer-only change. The complete Desktop UI suite passed.Documentation & Housekeeping
docs/, docstrings) — N/A; existing behavior is extended without a user-facing configuration changecli-config.yaml.exampleif I added/changed config keys — N/A; no config changesCONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/A; no architecture/workflow changesScreenshots / Logs
Before, ordinary flat All Profiles rows showed repeated
Bot Chattitles with no profile ownership marker. After, the same rows show their existing named-profile color/initial glyphs; profile grouping removes the now-redundant row glyphs.Native visual validation and the complete Desktop UI suite are reported above.