fix(gateway): profile editors hide opt-in toolsets the profile hasn't enabled - #86239
Merged
Merged
Conversation
… enabled Follow-up to #86227: _DEFAULT_OFF_TOOLSETS entries (a2a, spotify, discord, video, x_search, ...) and the region-specific yuanbao are global opt-ins configured via `hermes tools`/Settings; showing them unchecked in every per-profile capabilities editor is noise, and showing a2a at all confuses users who never enabled agent-to-agent serving (tester report). Enabled ones still show — hiding an ACTIVE toolset would misrepresent the profile.
૮ >ﻌ< ა ci reviewran on 790c973 — fix(gateway): profile editors hide opt-in toolsets the profi
|
alt-glitch
added
type/bug
skappafrost
pushed a commit
to skappafrost/hermes-agent
that referenced
this pull request
Aug 15, 2026
… enabled (NousResearch#86239) Follow-up to NousResearch#86227: _DEFAULT_OFF_TOOLSETS entries (a2a, spotify, discord, video, x_search, ...) and the region-specific yuanbao are global opt-ins configured via `hermes tools`/Settings; showing them unchecked in every per-profile capabilities editor is noise, and showing a2a at all confuses users who never enabled agent-to-agent serving (tester report). Enabled ones still show — hiding an ACTIVE toolset would misrepresent the profile.
bobaba76
pushed a commit
to bobaba76/hermes-agent
that referenced
this pull request
Aug 27, 2026
… enabled (NousResearch#86239) Follow-up to NousResearch#86227: _DEFAULT_OFF_TOOLSETS entries (a2a, spotify, discord, video, x_search, ...) and the region-specific yuanbao are global opt-ins configured via `hermes tools`/Settings; showing them unchecked in every per-profile capabilities editor is noise, and showing a2a at all confuses users who never enabled agent-to-agent serving (tester report). Enabled ones still show — hiding an ACTIVE toolset would misrepresent the profile.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
… enabled (NousResearch#86239) Follow-up to NousResearch#86227: _DEFAULT_OFF_TOOLSETS entries (a2a, spotify, discord, video, x_search, ...) and the region-specific yuanbao are global opt-ins configured via `hermes tools`/Settings; showing them unchecked in every per-profile capabilities editor is noise, and showing a2a at all confuses users who never enabled agent-to-agent serving (tester report). Enabled ones still show — hiding an ACTIVE toolset would misrepresent the profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #86227 (tester report:
yuanbaoanda2astill listed)._DEFAULT_OFF_TOOLSETSentries and the region-specificyuanbaoare global opt-ins thathermes tools/Settings own; a per-profile capabilities editor listing them unchecked is noise at best and confusing at worst (a2a means nothing to a user who never set up agent-to-agent serving). Rule: opt-in toolsets appear only when actually enabled for the profile — hiding an active one would misrepresent the profile, so enabled ones always show.E2E: describe on a live profile now lists only core user-facing toolsets; yuanbao/a2a absent unless enabled.