fix(desktop): dial pooled profile backends on tab switch - #86130
Closed
infinitycrew39 wants to merge 2 commits into
Closed
fix(desktop): dial pooled profile backends on tab switch#86130infinitycrew39 wants to merge 2 commits into
infinitycrew39 wants to merge 2 commits into
Conversation
NousResearch#85665 tagged shared-primary routes with `.profile`, but local pooled backends and per-profile remote overrides use the same field for REST routing. sharedPrimaryRoute therefore reused the primary socket and profile tab switches stayed on the default workspace (NousResearch#85745). Tag only the true shared-primary descriptor with sharedPrimary and refresh the sidebar session list when the active gateway profile changes.
Cover local pool descriptors that carry profile without sharedPrimary, so profile tab switches keep dialing the profile backend.
Contributor
Author
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sharedPrimaryRoute()treated any connection descriptor with aprofilefield as shared-primary — but local pooledservebackends and per-profile remote overrides also carryprofilefor REST routing.sharedPrimary: true, and refresh sidebar sessions when the active gateway profile changes.Test plan
npx vitest run src/store/gateway-shared-remote.test.ts(apps/desktop)Fixes #85745
Made with Cursor