fix(terminal): inline CI-poller hint instead of dead skill_view pointer - #85984
Draft
steveonjava wants to merge 3 commits into
Draft
fix(terminal): inline CI-poller hint instead of dead skill_view pointer#85984steveonjava wants to merge 3 commits into
steveonjava wants to merge 3 commits into
Conversation
The homebrew-CI-poller hint in terminal_tool told agents to run skill_view(name='github/github-pr-workflow', file_path='references/green-ci-policy.md') for the full write-up. That file never existed, so every agent who hit the hint and followed it got a dead pointer instead of guidance. I inlined the exit-code and column-2-awk snippets directly into the hint string instead of adding a new skill file. Stephen's call on this: a skill created solely to satisfy one hint, while roughly two dozen other dead pointers to the same imaginary skill still exist elsewhere in the repo, would manufacture a real file to justify a broken convention. The hint now stands on its own. I restored the three tests removed by 3997561: the statusCheckRollup shape firing the hint, the `gh pr checks | jq` shape firing the hint, and the canonical awk-on-tabs and exit-code-driven shapes NOT false-positiving. Updated the assertions and docstrings to describe green-ci-policy as the named convention the hint documents inline, not a file to go read.
Independent edge-case coverage on top of the 4 restored tests: jq-substring false-positive guard, foreground-only statusCheckRollup non-fire, and single-fire dedup when multiple qualifying signals appear in one command.
15 tasks
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homebrew CI-poller hint in terminal_tool told agents to run
skill_view(name='github/github-pr-workflow', file_path='references/green-ci-policy.md')for the full write-up. That file never existed, so every agent who
hit the hint and followed it got a dead pointer instead of guidance.
Inlined the exit-code and column-2-awk snippets directly into the
hint string instead of adding a new skill file. A skill created
solely to satisfy one hint, while roughly two dozen other dead
pointers to the same imaginary skill still exist elsewhere in the
repo, would manufacture a real file to justify a broken convention.
The hint now stands on its own.
Restored the three tests removed by 3997561 (statusCheckRollup
shape firing the hint,
gh pr checks | jqshape firing the hint,canonical awk-on-tabs / exit-code-driven shapes NOT false-positiving),
plus added independent adversarial coverage for edge cases: jq
appearing as a substring of another word must not false-positive,
foreground-only statusCheckRollup must not fire, and multiple
qualifying signals in one command still fire exactly once.
Refs #31329, #31448, #31695, #31709, #31745, #32264, #33131
Supersedes #83029