fix(gateway): exclude service-managed PIDs from orphan reaping - #85743
Closed
JonthanaHanh wants to merge 1 commit into
Closed
JonthanaHanh wants to merge 1 commit into
JonthanaHanh wants to merge 1 commit into
Conversation
_reap_unsupervised_gateway_orphans() kills every gateway PID found by find_gateway_pids() on hosts without systemd (macOS launchd, Windows Scheduled Task). This includes service-managed gateways that are NOT orphans — they are supervised by launchd/systemd and should never be killed during a stale-process sweep. Add own |= _get_service_pids() to the exclusion set before scanning, so launchd/systemd-supervised gateways are preserved. True orphans (reparented leftovers not present in launchctl/systemctl) are still found and reaped, preserving the NousResearch#77276 protection. Fixes NousResearch#85344 (macOS launchd gateway killed by desktop serve startup) Fixes NousResearch#85044 (Windows Scheduled Task gateway killed by desktop serve) Fixes NousResearch#84855 (Permission denied to kill orphaned gateway PID) Fixes NousResearch#85368 (gateway process repeatedly killed, messaging offline)
This was referenced Aug 14, 2026
alt-glitch
added
type/bug
teknium1
added a commit
that referenced
this pull request
Aug 15, 2026
…r to all platforms Compose the service-PID exclusion (#85743, RelaxJonh) and the recorded-PID + parent-chain exemption (#86100, arccat-114) into one cross-platform rule: - _get_service_pids() exclusion now runs unconditionally, not only under is_macos() — it is the authoritative "supervised" signal for launchd and any systemd unit visible on a host that got past the systemd gate. - The recorded-healthy-gateway (get_running_pid()) + parent-chain exemption now runs on every platform, not only Windows. A recorded, liveness-verified gateway is by definition not an orphan "the pidfile/runtime record can't see", so the reaper must never target it — this covers Windows Scheduled Task / Startup VBS supervision, standalone launcher-started gateways (the case #85743 alone would miss), and macOS/WSL equivalents. True orphans (no service registration, no valid runtime record) are still found and reaped, preserving the #51325/#75936 duplicate-port protection. Existing macOS regression tests updated to pin get_running_pid to None for their scenario; Windows regression tests from #86100 carry over unchanged. Bug class: #83683 (root), #86287, #86098, #85738, #85368, #85344, #85044, #84855, #84824, #84200.
Collaborator
|
Thanks @JonthanaHanh — the service-managed PID exclusion you built here was the right instinct, and the recorded-registry angle in your approach informed the final design. This landed via #86658, which consolidated the supervised-gateway detection across all three platforms (systemd, Windows Scheduled Task, macOS launchd) plus the recorded-healthy guard, so one fix covers every reap path. Credit noted in the salvage PR body. Closing as superseded by #86658 (merged, 169ff2d). |
bobaba76
pushed a commit
to bobaba76/hermes-agent
that referenced
this pull request
Aug 27, 2026
…r to all platforms Compose the service-PID exclusion (NousResearch#85743, RelaxJonh) and the recorded-PID + parent-chain exemption (NousResearch#86100, arccat-114) into one cross-platform rule: - _get_service_pids() exclusion now runs unconditionally, not only under is_macos() — it is the authoritative "supervised" signal for launchd and any systemd unit visible on a host that got past the systemd gate. - The recorded-healthy-gateway (get_running_pid()) + parent-chain exemption now runs on every platform, not only Windows. A recorded, liveness-verified gateway is by definition not an orphan "the pidfile/runtime record can't see", so the reaper must never target it — this covers Windows Scheduled Task / Startup VBS supervision, standalone launcher-started gateways (the case NousResearch#85743 alone would miss), and macOS/WSL equivalents. True orphans (no service registration, no valid runtime record) are still found and reaped, preserving the NousResearch#51325/NousResearch#75936 duplicate-port protection. Existing macOS regression tests updated to pin get_running_pid to None for their scenario; Windows regression tests from NousResearch#86100 carry over unchanged. Bug class: NousResearch#83683 (root), NousResearch#86287, NousResearch#86098, NousResearch#85738, NousResearch#85368, NousResearch#85344, NousResearch#85044, NousResearch#84855, NousResearch#84824, NousResearch#84200.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…r to all platforms Compose the service-PID exclusion (NousResearch#85743, RelaxJonh) and the recorded-PID + parent-chain exemption (NousResearch#86100, arccat-114) into one cross-platform rule: - _get_service_pids() exclusion now runs unconditionally, not only under is_macos() — it is the authoritative "supervised" signal for launchd and any systemd unit visible on a host that got past the systemd gate. - The recorded-healthy-gateway (get_running_pid()) + parent-chain exemption now runs on every platform, not only Windows. A recorded, liveness-verified gateway is by definition not an orphan "the pidfile/runtime record can't see", so the reaper must never target it — this covers Windows Scheduled Task / Startup VBS supervision, standalone launcher-started gateways (the case NousResearch#85743 alone would miss), and macOS/WSL equivalents. True orphans (no service registration, no valid runtime record) are still found and reaped, preserving the NousResearch#51325/NousResearch#75936 duplicate-port protection. Existing macOS regression tests updated to pin get_running_pid to None for their scenario; Windows regression tests from NousResearch#86100 carry over unchanged. Bug class: NousResearch#83683 (root), NousResearch#86287, NousResearch#86098, NousResearch#85738, NousResearch#85368, NousResearch#85344, NousResearch#85044, NousResearch#84855, NousResearch#84824, NousResearch#84200.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_reap_unsupervised_gateway_orphans()kills every gateway PID found byfind_gateway_pids()on hosts without systemd (macOS launchd, Windows Scheduled Task). This includes service-managed gateways that are NOT orphans — they are supervised by launchd/systemd and should never be killed during a stale-process sweep.The function's own docstring says
exclude_pidsis for "service-managed PIDs that should not be killed during a stale-process sweep", but it only excludes its own PID — not service-managed ones.Root Cause
_reap_unsupervised_gateway_orphans()callsfind_gateway_pids(exclude_pids=own)whereownonly contains{os.getpid()}plusextra_exclude.find_gateway_pids()includes_get_service_pids()in its results (line 634), but those service-managed PIDs are NOT in the exclusion set — so they get reaped.Fix
Add
own |= _get_service_pids()to the exclusion set before scanning, wrapped in try/except for robustness. This preserves the #77276 orphan protection while excluding launchd/systemd-supervised gateways.True orphans (reparented leftovers not present in
launchctl list/systemctl) are still found and reaped.Changes
hermes_cli/gateway.py: Add 5 lines in_reap_unsupervised_gateway_orphans()to exclude_get_service_pids()from the reap target set.Test Plan
Fixes #85344
Fixes #85044
Fixes #84855
Fixes #85368