Skip to content

fix(models): refresh xAI picker via models.dev; pin grok-4.6 - #85683

Closed
Jaaneek wants to merge 1 commit into
NousResearch:mainfrom
Jaaneek:fix/xai-models-dev-picker-time
Closed

Jaaneek wants to merge 1 commit into
NousResearch:mainfrom
Jaaneek:fix/xai-models-dev-picker-time

Conversation

@Jaaneek

@Jaaneek Jaaneek commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

models from xAI could get stale in the picker, also set grok-4.6 to default

Related Issue

Related upstream context:

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • hermes_cli/models.py — add xai / xai-oauth to _MODELS_DEV_PREFERRED; remove the xai-oauth early return in provider_model_ids; pin grok-4.6 after merge
  • hermes_cli/model_setup_flows.py — OAuth setup picks models via provider_model_ids("xai-oauth") (same path as /model)
  • tests/hermes_cli/test_xai_curated_models.py — preferred membership + call-time merge + pin regressions
  • website/docs/guides/xai-grok-oauth.md (+ zh-Hans) — document grok-4.6 as default/pin

How to Test

  1. Run CI-parity tests:
    scripts/run_tests.sh tests/hermes_cli/test_xai_curated_models.py tests/hermes_cli/test_models_dev_preferred_merge.py -q
  2. With xAI OAuth configured, open /model (or hermes setup model flow) and confirm grok-4.6 is first.
  3. After models.dev cache refresh (~/.hermes/models_dev_cache.json), confirm a newly listed Grok ID appears in the OAuth picker without restarting Hermes.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run scripts/run_tests.sh on the touched tests and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Ubuntu Linux (devbox) via scripts/run_tests.sh

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A (pure catalog merge logic)
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

N/A — catalog plumbing; covered by unit tests.

Stop freezing the xAI/xAI-OAuth catalog at import so /model and setup
pick up new Grok IDs after the models.dev cache refreshes. Put xai and
xai-oauth on the shared picker-time models.dev merge path and pin
grok-4.6 as the default headline model.
@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard provider/xai xAI (Grok) P2 Medium — degraded but workaround exists labels Aug 13, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Merged via PR #85802 — your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks @Jaaneek!

@teknium1 teknium1 closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists provider/xai xAI (Grok) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants