fix(acp): resolve Windows resource-link path and CRLF handling. - #85667
Closed
iamiskender wants to merge 4 commits into
Closed
fix(acp): resolve Windows resource-link path and CRLF handling.#85667iamiskender wants to merge 4 commits into
iamiskender wants to merge 4 commits into
Conversation
…ors in doctor journal tests
…rmalize CRLF when inlining text
alt-glitch
added
type/bug
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What -
_path_from_file_uriwas unconditionally translating Windows drive-letter paths (C:\...) to WSL-style/mnt/c/...paths, even when Hermes runs natively on Windows. This broke ACP resource_link resolution (FileNotFoundError) on native Windows. -_decode_text_bytesdidn't normalize CRLF line endings, so inlined resource text embedded raw\rbytes when the source file was written with Windows line endings. ## Fix - Only translate to/mnt/<drive>/...when NOT running onwin32; otherwise resolve to the native drive-letter path. - Normalize\r\n/\rto\nwhen decoding resource text. ## Testingpytest tests/acp_adapter/— 15 passed (was 1 failing before the fix).