feat(webhook): complete CLI management parity (Webhook Feature Package)

[andrexibiza]

Part of the Webhook Feature Package Feature Package. Task 15.

CLI management parity

• show (human + --json, secret masked on read)
• update (patch fields, preserve unknown legacy data)
• enable / disable (toggle without removal)
• rotate-secret (surface new secret once)
• subscribe --replace (explicit conflict on existing name; default errors)
• --profile support (profile-scoped subscription storage)
• --json output for list and show (secret-safe)

Verification

20 CLI tests pass (8 new), 63 total with regression. git diff --check clean.

[Enough1122]

AI code review — automated review for reference, author can ignore or act on any point.

feat(webhook): complete CLI management parity (Webhook Feature Package)

Useful CLI additions with good secret hygiene (masked reads, rotate-shows-once). Points:

1. contributors/emails/andrexibiza@gmail.com now contains # campaign authorship — a marker comment inside a contributor-credit file. This looks like automation metadata leaking into a tracked file; the credit file should contain just the contributor name. Also note this same file is added (with the marker) across every PR in this series.

2. _cmd_update cannot clear a field — empty-string flags mean "no change" (if args.prompt:), so there is no way to unset prompt, description, deliver, or skills. Consider a --clear-<field> option or documenting that clearing requires subscribe --replace.

3. Cross-PR integration with secret references — _cmd_rotate_secret writes the new secret back as plaintext route["secret"] and _cmd_subscribe/update write plaintext too. fix(security): store webhook secrets by reference and migrate plaintext (Webhook Feature Package) #85025 moves secrets to secret_ref + the profile backend; once that lands, these CLI paths will re-introduce plaintext secrets into webhook_subscriptions.json. Coordinate so the CLI writes via _store_route_secret / the canonical model after fix(security): store webhook secrets by reference and migrate plaintext (Webhook Feature Package) #85025 merges.

4. _redact_secret masking is minimal but consistent — "***" for ≤8 chars, head+tail otherwise; the --json output uses the same mask (tested). Fine for a management CLI; just be aware masked values are still informative for short secrets (e.g., a 6-char secret shows only ***, which is safe).

5. Good: subscribe now refuses to silently overwrite without --replace (tested), and all commands accept --profile.

[andrexibiza]

Decision recorded against current main 3a034356a237341452b7afebd3a2bfd21021609f.

CLI parity must follow the canonical storage/security owners, not preserve the current direct-JSON/plaintext path. Land order:

1. feat(webhook): add canonical route model and profile-aware store (Webhook Feature Package) #84978 — canonical WebhookRouteConfig + profile-aware locked/atomic store
2. fix(webhook): preserve profile-correct effective config through semantic train compression #85002 — effective named-profile configuration
3. fix(security): store webhook secrets by reference and migrate plaintext (Webhook Feature Package) #85025 — secret-ref migration/resolution
4. feat(webhook): complete CLI management parity (Webhook Feature Package) #85634 — CLI commands implemented only through those owners

Required rework before landing:

• subscribe, update, and rotate-secret must write secret_ref through the profile secret backend; no plaintext route["secret"] may re-enter webhook_subscriptions.json;
• profile selection must resolve to the same profile-scoped store/runtime path used by REST and the adapter;
• add an explicit clear/unset contract rather than overloading empty strings as “no change”;
• preserve unknown legacy fields through the canonical model;
• rotate atomically, reveal the generated secret once, and prove rollback leaves the prior reference usable;
• remove campaign-marker residue from the contributor mapping and rerun attribution.

The decision is complete. The current head predates the canonical store/secret-ref composition and is not landable unchanged.