fix(hindsight): show embedded config in desktop - #85375
Closed
aikeepsitreal wants to merge 1 commit into
Closed
Conversation
aikeepsitreal
marked this pull request as ready for review
August 13, 2026 14:58
Collaborator
Related: #84586 and #58924 address the same Hindsight Desktop configuration family through broader declared-schema changes. This PR preserves existing setup-created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84572 by making Desktop represent existing Hindsight
local_embeddedconfiguration honestly without bypassing the setup flow that installs its runtime dependencies.local_embeddedmode as a disabled, read-only select option instead of displaying the Cloud defaultHINDSIGHT_LLM_API_KEYlocal_embeddedsetup-owned, while allowing edits to an already configured embedded installationRoot cause
The generic declared-config serializer replaced stored select values outside a surface's write allow-list with the field default. Hindsight intentionally omits
local_embeddedfrom Desktop's writable Mode options becausehermes memory setupowns dependency installation, but that caused a valid setup-created value to render as Cloud. The declared schema also omitted the embedded LLM fields and secret mapping.User impact
Users with Hindsight Local Embedded configured through setup now see their actual mode and LLM settings in Desktop and can edit those settings safely. Desktop still cannot create a partially installed embedded configuration.
Validation
152 passed, 1 skippedacross the current Hindsight schema and full web-server test files10 passedin the Desktop provider-config panel testgit diff --checkpassed