Skip to content

fix: honor max turns in ACP sessions - #85240

Closed
s-c-h-a-f-e-r wants to merge 1 commit into
NousResearch:mainfrom
s-c-h-a-f-e-r:fix/acp-max-turns-propagation
Closed

fix: honor max turns in ACP sessions#85240
s-c-h-a-f-e-r wants to merge 1 commit into
NousResearch:mainfrom
s-c-h-a-f-e-r:fix/acp-max-turns-propagation

Conversation

@s-c-h-a-f-e-r

Copy link
Copy Markdown

ACP currently loads config.yaml but omits agent.max_turns when constructing AIAgent, leaving ACP/Buzz sessions capped at the constructor default of 90.

This passes a validated positive agent.max_turns as max_iterations while preserving the constructor default for missing or invalid values.

Verification:

  • python -m pytest tests/acp/test_session.py -o "addopts=" -q (24 passed)
  • python -m pytest tests/acp -o "addopts=" -q (135 passed, 2 pre-existing AsyncMock warnings)
  • python -m compileall -q acp_adapter/session.py tests/acp/test_session.py
  • git diff --check

Co-authored-by: Justin Schafer <11656082+justinfschafer@users.noreply.github.com>
Signed-off-by: Justin Schafer <11656082+justinfschafer@users.noreply.github.com>
@alt-glitch alt-glitch added type/bug Something isn't working P4 Best-effort: we will get to it when we get to it (no commitment) comp/acp Agent Communication Protocol adapter area/config Config system, migrations, profiles duplicate This issue or pull request already exists labels Aug 13, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #70592. Both PRs implement the same validated agent.max_turns to ACP max_iterations propagation; #70592 was opened first and is the canonical implementation.

@s-c-h-a-f-e-r

Copy link
Copy Markdown
Author

Closing as duplicate of #70592. The local regression coverage here independently confirmed the same ACP propagation gap: 135 ACP tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/acp Agent Communication Protocol adapter duplicate This issue or pull request already exists P4 Best-effort: we will get to it when we get to it (no commitment) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants