fix(sdk): keep all-profiles sidebar scope on cross-profile openSession - #85155
Merged
Merged
Conversation
ensureGatewayProfile narrows the Sessions sidebar to the activated profile as a side effect, so every cross-profile open from a plugin surface silently locked the user into that profile's session list. A plugin-driven open is a navigation, not a scope choice: openSession now restores the unified all-profiles view after a cross-profile activation (keepAllProfilesScope, default true; pass false for the old narrowing). Same-profile opens write no scope at all.
Contributor
૮ >ﻌ< ა ci reviewran on e76a7fb — fix(sdk): keep all-profiles sidebar scope on cross-profile o
|
skappafrost
pushed a commit
to skappafrost/hermes-agent
that referenced
this pull request
Aug 15, 2026
NousResearch#85155) ensureGatewayProfile narrows the Sessions sidebar to the activated profile as a side effect, so every cross-profile open from a plugin surface silently locked the user into that profile's session list. A plugin-driven open is a navigation, not a scope choice: openSession now restores the unified all-profiles view after a cross-profile activation (keepAllProfilesScope, default true; pass false for the old narrowing). Same-profile opens write no scope at all.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
NousResearch#85155) ensureGatewayProfile narrows the Sessions sidebar to the activated profile as a side effect, so every cross-profile open from a plugin surface silently locked the user into that profile's session list. A plugin-driven open is a navigation, not a scope choice: openSession now restores the unified all-profiles view after a cross-profile activation (keepAllProfilesScope, default true; pass false for the old narrowing). Same-profile opens write no scope at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #85093.
host.openSession(id, { profile })performs the soft profile swap viaensureGatewayProfile, which points the live gateway at the target profile — and as a side effect the Sessions sidebar narrows to that profile's sessions. For a plugin surface that navigates across profiles (e.g. a bot-roster pane opening each agent's chat), the user gets silently locked into the target profile's session list and has to click back to the all-profiles view by hand every time.A cross-profile open from a plugin is a navigation, not a scope choice.
Fix
host.openSessiongainskeepAllProfilesScope(defaulttrue): after a cross-profile activation it callssetShowAllProfiles(true), so the sidebar stays in the unified all-profiles view while the chat itself opens under the right backend. Passingfalserestores the previous behavior (scope the sidebar to the target profile). Same-profile opens are untouched — no scope writes at all.Verification
Renderer compiles; behavior exercised via the hermes-bots roster plugin: clicking bots across profiles now leaves the Sessions sidebar in the unified view, and
keepAllProfilesScope: falsereproduces the old narrowing.