fix: profiles.create mirrors launch credentials so new profiles can run - #85111
Merged
Merged
Conversation
A profile created through the headless ws door (profiles.create, #85093) was born with no inference provider: create_profile() seeds a comment-only .env, never copies auth.json, and a fresh profile has no config.yaml. Its first message failed with 'No inference provider configured' and the flow has no interactive setup step to recover with. New mirror_credentials param (default true): copy the launch profile's .env (only over the seeded stub — never clobber cloned secrets) and auth.json (only when absent), both chmod 600, and inherit model.provider/model.default when the caller gave no explicit pin and no config was cloned. mirror_credentials:false preserves the old isolated behavior byte-for-byte. Result gains a mirrored:{env,auth,model_inherited} receipt. CLI and REST create paths untouched.
Contributor
૮ >ﻌ< ა ci reviewran on ba2a1fe — fix: profiles.create mirrors launch credentials so new profi
|
skappafrost
pushed a commit
to skappafrost/hermes-agent
that referenced
this pull request
Aug 15, 2026
…un (NousResearch#85111) A profile created through the headless ws door (profiles.create, NousResearch#85093) was born with no inference provider: create_profile() seeds a comment-only .env, never copies auth.json, and a fresh profile has no config.yaml. Its first message failed with 'No inference provider configured' and the flow has no interactive setup step to recover with. New mirror_credentials param (default true): copy the launch profile's .env (only over the seeded stub — never clobber cloned secrets) and auth.json (only when absent), both chmod 600, and inherit model.provider/model.default when the caller gave no explicit pin and no config was cloned. mirror_credentials:false preserves the old isolated behavior byte-for-byte. Result gains a mirrored:{env,auth,model_inherited} receipt. CLI and REST create paths untouched.
bobaba76
pushed a commit
to bobaba76/hermes-agent
that referenced
this pull request
Aug 27, 2026
…un (NousResearch#85111) A profile created through the headless ws door (profiles.create, NousResearch#85093) was born with no inference provider: create_profile() seeds a comment-only .env, never copies auth.json, and a fresh profile has no config.yaml. Its first message failed with 'No inference provider configured' and the flow has no interactive setup step to recover with. New mirror_credentials param (default true): copy the launch profile's .env (only over the seeded stub — never clobber cloned secrets) and auth.json (only when absent), both chmod 600, and inherit model.provider/model.default when the caller gave no explicit pin and no config was cloned. mirror_credentials:false preserves the old isolated behavior byte-for-byte. Result gains a mirrored:{env,auth,model_inherited} receipt. CLI and REST create paths untouched.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…un (NousResearch#85111) A profile created through the headless ws door (profiles.create, NousResearch#85093) was born with no inference provider: create_profile() seeds a comment-only .env, never copies auth.json, and a fresh profile has no config.yaml. Its first message failed with 'No inference provider configured' and the flow has no interactive setup step to recover with. New mirror_credentials param (default true): copy the launch profile's .env (only over the seeded stub — never clobber cloned secrets) and auth.json (only when absent), both chmod 600, and inherit model.provider/model.default when the caller gave no explicit pin and no config was cloned. mirror_credentials:false preserves the old isolated behavior byte-for-byte. Result gains a mirrored:{env,auth,model_inherited} receipt. CLI and REST create paths untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
profiles.create(the ws RPC added in #85093) produced profiles that could not run a single turn:create_profile()deliberately seeds a comment-only.env, never copiesauth.json, and a fresh (non-cloned) profile has noconfig.yaml— so the first message from a plugin-created profile failed with:That default is right for the interactive CLI (
hermes profile createis followed by<profile> setup), but the headless ws path has no setup step to recover with — a profile spawned as an always-available teammate must be able to think out of the box.Fix
profiles.creategainsmirror_credentials(defaulttrue):.env→ new profile (chmod 600) — only when the source has real (non-comment) content and the destination does NOT (never clobbers secrets aclone_frombrought along)auth.json(OAuth tokens / credential pools) → new profile (chmod 600) — only when absent at the destinationmodel+providerpin and no config was cloned, inherit the launch profile'smodel.provider/model.defaultvia the same_write_profile_modelwriter the pin path usesCallers that want an isolated, credential-free profile pass
mirror_credentials: false— that path is byte-identical to the old behavior. Result payload gains amirrored: {env, auth, model_inherited}receipt.Not touched:
hermes profile createCLI andPOST /api/profilesREST keep their existing semantics — this is scoped to the headless ws door where the failure class lives.Verification
Exercised end-to-end against the real registry (
server._methods["profiles.create"]dispatch), no mocks:mirrored: {env: true, auth: true, model_inherited: true}; on disk the new profile's.envhas real keys,auth.jsonpresent,config.yamlcarriesprovider: nous/default: <model>; first-turn provider resolution succeedsmirror_credentials: false:mirroredall false,.envstays the comment-only stub, noauth.json, noconfig.yaml— old behavior preservedhermes profile deleteSymptom observed live: a
profiles.create-born profile ("mr-tester") erroring "No inference provider configured" on its first message in the desktop app.