Skip to content

fix(gateway): support dedicated lifecycle channels #84874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Malk13r wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(gateway): support dedicated lifecycle channels #84874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0208a1
fix(gateway): support dedicated lifecycle channels
Malk13r Aug 12, 2026
1c6c9d4
fix(gateway): harden lifecycle channel routing
Malk13r Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 75 additions & 3 deletions gateway/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,9 @@ class PlatformConfig:
token: Optional[str] = None # Bot token (Telegram, Discord)
api_key: Optional[str] = None # API key if different from token
home_channel: Optional[HomeChannel] = None
# Optional operations destination for gateway lifecycle notices. When
# unset, notices retain the historical home-channel fallback.
gateway_restart_channel: Optional[HomeChannel] = None

# Reply threading mode (Telegram/Slack)
# - "off": Never thread replies to original message
Expand Down Expand Up @@ -696,19 +699,64 @@ def to_dict(self) -> Dict[str, Any]:
result["api_key"] = self.api_key
if self.home_channel:
result["home_channel"] = self.home_channel.to_dict()
if self.gateway_restart_channel:
result["gateway_restart_channel"] = self.gateway_restart_channel.to_dict()
if self.channel_overrides:
result["channel_overrides"] = {
cid: ov.to_dict() for cid, ov in self.channel_overrides.items()
}
return result

@classmethod
def from_dict(cls, data: Dict[str, Any]) -> "PlatformConfig":
def from_dict(
cls,
data: Dict[str, Any],
*,
expected_platform: Optional[Platform] = None,
) -> "PlatformConfig":
data = _coerce_dict(data)
home_channel = None
if isinstance(data.get("home_channel"), dict):
home_channel = HomeChannel.from_dict(data["home_channel"])

gateway_restart_channel = None
raw_restart_channel = data.get("gateway_restart_channel")
if raw_restart_channel is not None:
if isinstance(raw_restart_channel, dict):
try:
raw_chat_id = raw_restart_channel.get("chat_id")
if raw_chat_id is None or not str(raw_chat_id).strip():
raise ValueError("chat_id must be non-empty")
gateway_restart_channel = HomeChannel.from_dict(
raw_restart_channel
)
except (KeyError, TypeError, ValueError) as exc:
logger.warning(
"Ignoring invalid gateway_restart_channel; "
"lifecycle notices will fall back to the home channel: %s",
exc,
)
else:
logger.warning(
"Ignoring invalid gateway_restart_channel; expected a mapping, "
"got %s",
type(raw_restart_channel).__name__,
)

if (
gateway_restart_channel is not None
and expected_platform is not None
and gateway_restart_channel.platform != expected_platform
):
logger.warning(
"Ignoring gateway_restart_channel platform mismatch; "
"expected %s, got %s; lifecycle notices will fall back "
"to the home channel",
expected_platform.value,
gateway_restart_channel.platform.value,
)
gateway_restart_channel = None

# gateway_restart_notification may be bridged into extra via the
# shared-key loop in load_gateway_config(); check both top-level
# and extra so YAML ``discord: gateway_restart_notification: false``
Expand Down Expand Up @@ -743,6 +791,7 @@ def from_dict(cls, data: Dict[str, Any]) -> "PlatformConfig":
token=data.get("token"),
api_key=data.get("api_key"),
home_channel=home_channel,
gateway_restart_channel=gateway_restart_channel,
reply_to_mode=data.get("reply_to_mode", "first"),
gateway_restart_notification=_coerce_bool(_grn, True),
typing_indicator=_coerce_bool(_typing, True),
Expand Down Expand Up @@ -1143,7 +1192,9 @@ def from_dict(cls, data: Dict[str, Any]) -> "GatewayConfig":
continue
try:
platform = Platform(platform_name)
platforms[platform] = PlatformConfig.from_dict(platform_data)
platforms[platform] = PlatformConfig.from_dict(
platform_data, expected_platform=platform
)
except ValueError:
pass # Skip unknown platforms

Expand Down Expand Up @@ -1664,6 +1715,22 @@ def _merge_platform_map(source_platforms: Any) -> None:
bridged["channel_prompts"] = channel_prompts
if "gateway_restart_notification" in platform_cfg:
bridged["gateway_restart_notification"] = platform_cfg["gateway_restart_notification"]
has_restart_channel = "gateway_restart_channel" in platform_cfg
if has_restart_channel:
raw_restart_channel = platform_cfg.get("gateway_restart_channel")
plat_data, _extra = _ensure_platform_extra_dict(
platforms_data, plat.value
)
# _merge_platform_map already resolved precedence for
# gateway.platforms.* versus platforms.*. Only a direct
# top-level platform block may override that merged value.
# Preserve malformed values too so PlatformConfig can emit
# a warning instead of silently discarding user input.
if (
_cfg_toplevel
or "gateway_restart_channel" not in plat_data
):
plat_data["gateway_restart_channel"] = raw_restart_channel
if "typing_indicator" in platform_cfg:
bridged["typing_indicator"] = platform_cfg["typing_indicator"]
if "typing_status_text" in platform_cfg:
Expand Down Expand Up @@ -1699,7 +1766,12 @@ def _merge_platform_map(source_platforms: Any) -> None:
if isinstance(ov_data, dict)
}
enabled_was_explicit = _cfg_toplevel and "enabled" in platform_cfg
if not bridged and not enabled_was_explicit and not has_channel_overrides:
if (
not bridged
and not enabled_was_explicit
and not has_channel_overrides
and not has_restart_channel
):
continue
plat_data, extra = _ensure_platform_extra_dict(platforms_data, plat.value)
if enabled_was_explicit:
Expand Down
Loading