fix(discord): preserve native semantic thread renames - #84754
Closed
taikit wants to merge 1 commit into
Closed
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
only_if_current_nameno-clobber contractRoot cause
The shared gateway call passed
prefer_connector_createdandparent_chat_idto the native Discord adapter, whoserename_threadmethod does not accept those relay-only keywords. Python raisedTypeErrorbefore the adapter ran, and the broad handler logged only at DEBUG, so semantic title generation appeared successful while Discord remained unchanged.Verification
scripts/run_tests.sh tests/gateway/test_discord_semantic_thread_rename_contract.py tests/gateway/test_session_title_rename_lane.py tests/gateway/relay/test_relay_threads.py -q— 23 passedruff check gateway/run.py tests/gateway/test_discord_semantic_thread_rename_contract.py— passedgit diff --check— passed