Skip to content

fix(discord): preserve native semantic thread renames - #84754

Closed
taikit wants to merge 1 commit into
NousResearch:mainfrom
taikit:fix/discord-semantic-thread-rename-contract
Closed

fix(discord): preserve native semantic thread renames#84754
taikit wants to merge 1 commit into
NousResearch:mainfrom
taikit:fix/discord-semantic-thread-rename-contract

Conversation

@taikit

@taikit taikit commented Aug 12, 2026

Copy link
Copy Markdown

Summary

  • pass relay-only thread rename keywords only on the relay lane
  • preserve the native Discord adapter’s only_if_current_name no-clobber contract
  • surface unexpected rename failures at WARNING without logging exception messages or tracebacks
  • add behavior-level regression coverage for native, relay, and failure-observability paths

Root cause

The shared gateway call passed prefer_connector_created and parent_chat_id to the native Discord adapter, whose rename_thread method does not accept those relay-only keywords. Python raised TypeError before the adapter ran, and the broad handler logged only at DEBUG, so semantic title generation appeared successful while Discord remained unchanged.

Verification

  • scripts/run_tests.sh tests/gateway/test_discord_semantic_thread_rename_contract.py tests/gateway/test_session_title_rename_lane.py tests/gateway/relay/test_relay_threads.py -q — 23 passed
  • ruff check gateway/run.py tests/gateway/test_discord_semantic_thread_rename_contract.py — passed
  • git diff --check — passed
  • independent review — passed after changing to lane-specific kwargs and removing exception text/tracebacks from warning logs

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery platform/discord Discord bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages labels Aug 12, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related to #78495: both repair the native Discord semantic-rename signature mismatch, but this PR keeps relay-only kwargs in the relay lane while #78495 expands the native adapter signature. Maintainer choice needed.

@taikit taikit closed this Aug 12, 2026
@taikit
taikit deleted the fix/discord-semantic-thread-rename-contract branch August 12, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/discord Discord bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants