fix(google): stop treating Gemma as a Gemini thought_signature consumer - #84717
Closed
JoaoMarcos44 wants to merge 1 commit into
Closed
JoaoMarcos44 wants to merge 1 commit into
JoaoMarcos44 wants to merge 1 commit into
Conversation
_model_consumes_thought_signature matched any model name containing 'gemma' as well as 'gemini', so google/gemma-3-27b-it inherited a stale Gemini thought_signature and replayed it to the wrong family. Gemma is a distinct family with no thought_signature contract; match only 'gemini'. Closes NousResearch#84707
alt-glitch
added
type/bug
Contributor
Duplicate of #49218. Both PRs make the same Gemini-only predicate correction in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_model_consumes_thought_signaturematched"gemma" in min addition to"gemini", sogoogle/gemma-3-27b-itinherited a stale Geminithought_signatureand replayed it to the wrong family. Gemma has no thought_signature contract.Changes
"gemma"clause; only Gemini-family model names keepextra_content.Test Plan
tests/agent/transports/test_chat_completions.py: family gating (gemini=True, gemma=False, mistral=False) andconvert_messagesstripping staleextra_contentforgoogle/gemma-3-27b-it.scripts/run_tests.sh tests/agent/transports/test_chat_completions.py→ 48/48.Closes #84707