fix(scripts): read Hermes config.yaml as UTF-8 in discord-voice-doctor - #8453
Closed
Tianworld wants to merge 1 commit into
Closed
fix(scripts): read Hermes config.yaml as UTF-8 in discord-voice-doctor#8453Tianworld wants to merge 1 commit into
Tianworld wants to merge 1 commit into
Conversation
Voice diagnostics parse config.yaml with locale-default encoding; UTF-8 files on Windows could mis-parse or error. Made-with: Cursor
alt-glitch
added
type/bug
Collaborator
Contributor
|
Thanks for the focused Windows compatibility fix. This is an automated hermes-sweeper review; the requested behavior is already on current
Closing as implemented on main. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doctor script reads ~/.hermes/config.yaml for STT/TTS provider settings. Opening without encoding uses the process default on Windows and can mis-read valid UTF-8 YAML.
Made with Cursor