fix(memory): read plugin.yaml as UTF-8 in memory setup - #8450
Closed
Tianworld wants to merge 1 commit into
Closed
Conversation
plugin.yaml uses UTF-8; locale-default decoding on Windows could make yaml.safe_load fail inside a bare except, skipping pip dependency hints for the selected memory provider. Made-with: Cursor
alt-glitch
added
type/bug
Collaborator
|
Likely duplicate of #8467 — identical UTF-8 encoding fix for memory plugin.yaml reading on Windows. |
Contributor
|
Thanks for the focused Windows compatibility fix. This automated hermes-sweeper review found that the exact behavior is already implemented on current
Closing as implemented on main. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory setup loads plugins/memory//plugin.yaml to read pip_dependencies. The reader used the process default encoding; on Windows, valid UTF-8 YAML (e.g. non-ASCII description text) could fail parsing. The failure was swallowed, so users might not get pip install guidance when dependencies were missing.
Made with Cursor