fix(profile): read profile config.yaml as UTF-8 - #8447
Closed
Tianworld wants to merge 1 commit into
Closed
Conversation
_read_config_model used locale default encoding; on Windows, UTF-8 YAML with non-ASCII in model names failed yaml.safe_load and returned (None, None), hiding the active model in profile listings. Made-with: Cursor
alt-glitch
added
type/bug
Collaborator
Contributor
|
Closing as already fixed on Triage notes (high confidence): If you still see this on the latest version, please reopen with reproduction steps. (Bulk-closed during a CLI triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listing or resolving profiles, model/provider are read from each profile config.yaml. Without explicit UTF-8, Windows used the ANSI code page and valid UTF-8 files could fail parsing; the code then returned (None, None) and the UI showed no model despite a correct config.
Made with Cursor