fix(dump): latin-1 fallback for project .env - #8444
Closed
Tianworld wants to merge 1 commit into
Closed
Conversation
hermes dump loaded ~/.hermes/.env with UTF-8/latin-1 fallback but the repo-root .env used UTF-8 only, so Windows cp1252 project files could raise UnicodeDecodeError and skip keys in support output. Made-with: Cursor
alt-glitch
added
type/bug
Collaborator
|
Likely duplicate of #8415 — same .env UTF-8/latin-1 fallback for dump command. |
Contributor
|
Closing as already fixed on Triage notes (high confidence): If you still see this on the latest version, please reopen with reproduction steps. (Bulk-closed during a CLI triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\n\hermes dump\ loads ~/.hermes/.env\ with a latin-1 fallback after UTF-8, but the repository root .env\ was opened with UTF-8 only. On Windows, .env\ files edited in Notepad are often cp1252; that could raise \UnicodeDecodeError\ and leave project keys out of the pasted support bundle.\n\n## Change\nMirror the same try/UTF-8 / except/latin-1 pattern for the project .env, only when the file exists.
Made with Cursor