fix(xai): drop stale 256K grok-4.6 context cache - #84341
Julientalbot wants to merge 1 commit into
Conversation
|
Following this — Any estimate on when this is likely to merge? |
|
Landed on
This branch is now @lihongjie224 no remaining wait on this thread: pull current Delta this branch still had that #84661 did not: invalidate a persisted 256K cache leftover for |
593d7aa to
e0f6c65
Compare
|
Reopened. Closing this against #84661 was a mistake on my side. #84661 landed the catalog (500K / effort / floor) with no description and flipped the OpenRouter picker
Rebuilt onto current |
3d3a3d0 to
b5ccc8e
Compare
docs.x.ai (2026-08-12): grok-4.6 is the flagship, 500K context. Live GET /v1/models lists grok-4.6 at context_length 500000 (no grok-4.6-latest alias). NousResearch#84661 landed the catalog. Main already lists native grok-4.6 on the xAI picker. This is only the leftover cache guard (same pattern as grok-4.3): pre-catalog builds persisted the grok-4 catch-all (256K).
5f9271d to
e4aacc3
Compare
|
Rebuilt onto current Picker leftover is gone — |
|
Merged via PR #85434 — your commit was cherry-picked onto current main with your authorship preserved in git log (merged 91e550b). Thanks for self-pruning the parts #84661 superseded and keeping this a clean cache-guard delta, and for the E2E test. On top of your commit we generalized the guard: the per-model |
Summary
Official card (docs.x.ai/developers/models/grok-4.6): 500,000 context.
#84661 landed the catalog.
mainalready lists nativegrok-4.6on the xAI picker. This PR is only the leftover cache guard.Pre-catalog builds resolved
grok-4.6via thegrok-4catch-all (256K) and persisted it. After the catalog land the table is 500K, but a leftover cache entry still wins. Same pattern as the existing grok-4.3 guard.Not in this PR
main)xhighspecial-case4.5→4.6Test plan
uv run --extra dev pytest tests/agent/test_model_metadata.py::TestGrok46StaleCacheGuard tests/agent/test_model_metadata.py::TestGrok43StaleCacheGuard tests/agent/test_reasoning_stale_timeout_floor.py -q→ 40 passed