fix(desktop): keep all sessions when ALL-profiles scope is active with a single profile

[andyst-dev]

Fixes #84305

Problem

In the desktop app, choosing Grouping → Profile in the sidebar Filters menu
persists $showAllProfiles, which drives $profileScope to ALL_PROFILES even
when there is only a single profile (default). The sidebar then computed
showAllProfiles = multiProfile && profileScope === ALL_PROFILES, which is
false for a single profile — so the flat sessions list was filtered against
the __all__ sentinel (normalizeProfileKey(s.profile) === '__all__'), matching
nothing. Result: the sidebar's recents section rendered the empty state
("no sessions") even though the backend returned all rows for recents_profile=all.
Clicking the default chip (which leaves ALL scope) instantly restored the list.

The grouped rendering is intentionally gated on multiProfile (to avoid stranding
single-profile users in a grouped view with no rail), but the data scoping must
still fan every profile in when the scope is ALL.

Fix

Extract the scope selector into a pure helper, selectVisibleSessions(sessions, profileScope),
that treats ALL_PROFILES as "include everything" regardless of the multi-profile
grouping gate, and filters by concrete profile otherwise. scopedSessions now uses it,
so a single-profile user in the ALL scope sees their rows (as a flat list — the grouped
view stays off because it is still gated on multiProfile).

Tests

Added apps/desktop/src/app/chat/sidebar/session-scope.test.ts (6 tests) covering:

• ALL scope returns every session
• the regression: ALL scope with sessions owned by a single profile is not emptied
• concrete scope returns only the matching profile
• session profile normalization before matching
• null profile treated as default
• empty result when no session matches a concrete scope

Verified: new + existing sidebar tests pass (125 tests, 14 files), tsc --noEmit clean,
eslint clean.

[Enough1122]

AI code review — automated review for reference, author can ignore or act on any point.

fix(desktop): keep all sessions when ALL-profiles scope is active with a single profile

1. showAllProfiles was dropped from the useMemo dependency array (apps/desktop/src/app/chat/sidebar/index.tsx:448). The new selector treats profileScope as the single source of truth, and session-scope.ts documents the $showAllProfiles → $profileScope coupling — but if any path updates $showAllProfiles without $profileScope following (or vice versa), the recents list goes stale. Verify the two stores are always updated in lockstep (ideally profileScope derives from showAllProfiles in one place), otherwise keep showAllProfiles in the deps.
2. selectVisibleSessions normalizes the session side (normalizeProfileKey(s.profile)) but compares against the raw profileScope argument (session-scope.ts:135). A concrete scope carrying stray whitespace (' work ') would match nothing while the session side is trimmed. Normalize both sides for symmetry — the tests only cover a dirty session-side value.
3. In the ALL_PROFILES branch the selector returns the caller's array reference unchanged (session-scope.ts:131). Harmless for the memoized call site today, but any future caller that filters or mutates the result would mutate the source pool. A return [...sessions] would make the contract safer; minor.
4. The extracted selector is cleanly factored and the six tests pin the sentinel behavior, the single-profile ALL-scope regression, normalization, and null-profile handling — good coverage of the exact bug described.

[andyst-dev]

Rebased onto latest upstream main — resolved the import conflict with the session-index/session-scope split.

[Manu606972]

still hitting this after the Aug 18 update

[OutThisLife]

Superseded by #89817.

That salvage keeps the ALL-scope include-everything rule, rebased onto current main, and:

• uses the existing filterSessionsByProfileScope helper (cron and messaging already did)
• drops the new session-scope.ts / selectVisibleSessions duplicate
• adds the single-profile ALL-scope regression on that helper

You're credited via Co-authored-by. Thanks for pinning the Grouping > Profile empty-list path.