fix(acp): honor configured max turns

[desmond-rai]

Summary

• propagate agent.max_turns into ACP-created AIAgent instances
• retain root-level max_turns compatibility
• use the documented 500-turn default when no value is configured
• add regression coverage for ACP config propagation

Root cause

The ACP session manager loaded Hermes configuration but never passed max_iterations into AIAgent. Paseo and other ACP clients therefore silently used the constructor default instead of the user-configured value.

Verification

• uv run --extra dev --extra acp pytest -q tests/acp_adapter (15 passed)
• uv run --extra dev ruff check acp_adapter/session.py tests/acp_adapter/test_acp_commands.py
• python3 -m compileall -q acp_adapter/session.py tests/acp_adapter/test_acp_commands.py
• git diff --check

[alt-glitch]

This was generated by AI during triage.

Duplicate of #70592. Both propagate agent.max_turns into ACP-created AIAgent.max_iterations; #70592 is the earlier open implementation and validates the configured value before forwarding it.

[Enough1122]

AI code review — automated review for reference, author can ignore or act on any point.

PR: fix(acp): honor configured max turns

1. This overlaps with the earlier open fix(acp): honor configured max turns #70592, which propagates agent.max_turns into ACP-created AIAgent.max_iterations and additionally validates the configured value before forwarding it. Consider aligning with (or closing in favor of) that implementation so the two don't diverge in validation behavior.
2. max_iterations = agent_cfg.get("max_turns") or config.get("max_turns") or 500 performs no type/range validation. A YAML value such as max_turns: "150" (string) or a negative/zero value flows straight into AIAgent.max_iterations, where the loop's api_call_count < self.max_iterations comparison would raise a TypeError on a string. Coerce with int(...) and clamp to a sane minimum.
3. The or chain silently swallows an explicit 0 (falls through to the next source / 500). If 0 is meant to mean "no limit", document it; otherwise reject it explicitly so a user's intent is never silently overridden.