fix(cli): honor personality in oneshot mode - #84138
Open
wo-o wants to merge 1 commit into
Open
Conversation
wo-o
force-pushed
the
fix/oneshot-personality
branch
from
August 11, 2026 22:28
10cfe91 to
1f44229
Compare
Collaborator
Contributor
fix(cli): honor personality in oneshot mode No blocking issues found. Observations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes -zHERMES_EPHEMERAL_SYSTEM_PROMPTprecedence from normal CLI sessionsRoot cause
hermes -zbypassesHermesCLIand constructsAIAgentdirectly inhermes_cli/oneshot.py. That constructor path did not passephemeral_system_prompt, sodisplay.personalityandagent.system_promptwere silently ignored in one-shot mode.Test plan
scripts/run_tests.sh tests/hermes_cli/test_resolve_ephemeral_system_prompt.py tests/hermes_cli/test_oneshot_personality.py tests/hermes_cli/test_oneshot_usage_file.py tests/hermes_cli/test_oneshot_surrogate.py -q.venv/bin/ruff check hermes_cli/oneshot.py tests/hermes_cli/test_oneshot_personality.pyhermes -zcall with a strictHERMES_EPHEMERAL_SYSTEM_PROMPT, verified in the response and by tracing the exact constructor argument