fix(tests): mark routed profile as served in busy-mode test - #83745
fangliquanflq wants to merge 1 commit into
Conversation
Route resolution rejects targets outside the served set; the busy-mode boundary test only snapshotted research without marking it served.
After selective multiplex profile serving (NousResearch#83550), route resolution rejects target profiles missing from the served set, so this boundary test fell back to default interrupt on every CI slice (NousResearch#83743). Stamp research as served so the route-path assertion matches production rules. Same fixture shape as open NousResearch#83745.
After selective multiplex profile serving (NousResearch#83550), route resolution rejects target profiles missing from the served set, so this boundary test fell back to default interrupt on every CI slice (NousResearch#83743). Stamp research as served so the route-path assertion matches production rules. Same fixture shape as open NousResearch#83745.
After selective multiplex profile serving (NousResearch#83550), route resolution rejects target profiles missing from the served set, so this boundary test fell back to default interrupt on every CI slice (NousResearch#83743). Stamp research as served so the route-path assertion matches production rules. Same fixture shape as open NousResearch#83745.
|
This fix unblocks a large batch of open PRs — the same |
fix(tests): mark routed profile as served in busy-mode test No blocking issues found. A few minor observations:
|
|
Thanks for the review. No additional change is needed for either observation. The stub is intentionally narrow: this boundary test must make |
|
Thanks @fangliquanflq — reviewed against current Closing as redundant: the same repair landed in 8d1d193 / e8591ae (#97932, merged 2026-08-29). Credit for the diagnosis: your bisect with @OutThisLife (green at a31be48, red from c8f235a's served-set gate raising |
What does this PR do?
test_profile_route_and_nonmultiplexed_resolution_preserve_boundariesalways fails on CI after selective multiplex profile serving landed in c8f235a (feat(gateway): allow selective multiplex profile serving). Route resolution now rejects target profileresearchwhen it is not in_multiplex_profile_homes(config), so busy-input mode falls back to defaultinterruptinstead of the snapshottedsteer.This PR monkeypatches
_multiplex_profile_homesin that boundary test soresearchis in the served set. The test keeps asserting the multiplex / non-multiplex busy-mode boundary, not the serving allowlist. Bisect: green at a31be48, red from c8f235a.Related Issue
Fixes #83743
Type of Change
Changes Made
tests/gateway/test_multiplex_busy_input_mode.py- markresearchas served via_multiplex_profile_homesmonkeypatch in the profile-route boundary testHow to Test
scripts/run_tests.sh tests/gateway/test_multiplex_busy_input_mode.py -qtest_profile_route_and_nonmultiplexed_resolution_preserve_boundaries.assert 'interrupt' == 'steer'failure returns.Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
cli-config.yaml.example: N/A - no config key changedCONTRIBUTING.mdorAGENTS.md: N/A - no contributor workflow changed