Scrub secrets from profile export archives - #83458
Merged
Merged
Conversation
Shareable profile tarballs already drop auth.json/.env, but keys pasted into skills, SOUL.md, or memories still shipped in plaintext. Force-run the same redact_sensitive_text pass sessions export --redact uses on the staged copy so the live profile is never rewritten.
Contributor
૮ >ﻌ< ა ci reviewran on 6c5cb2d — fix(profiles): scrub secret-shaped strings from export archi
|
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…port-redact Scrub secrets from profile export archives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profile export already excludes
auth.json/.env, but secret-shaped strings sitting in skills,SOUL.md, memories, and other text still left the machine in the shareable.tar.gz. Export now force-runsagent.redact.redact_sensitive_text(..., force=True)on the staged copy (same pass ashermes sessions export --redact) before writing the archive.force=Trueignoressecurity.redact_secrets/HERMES_REDACT_SECRETS— share archives stay scrubbed even when live redaction is offTest plan
scripts/run_tests.sh tests/hermes_cli/test_profile_export_credentials.py -qsk-or-v1-…string in a skill/SOUL.mdand confirm the archive does not contain it while the source file still does