fix(gateway): resolve TypeError in suspend_recently_active on startup - #8336
Closed
ystyleb wants to merge 1 commit into
Closed
fix(gateway): resolve TypeError in suspend_recently_active on startup#8336ystyleb wants to merge 1 commit into
ystyleb wants to merge 1 commit into
Conversation
The suspend_recently_active() method used time.time() (float) to calculate
the cutoff timestamp, then compared it with entry.updated_at (datetime object),
causing: TypeError: '>=' not supported between instances of 'datetime.datetime' and 'float'
Changed cutoff calculation from:
cutoff = _time.time() - max_age_seconds
to:
cutoff = _now() - timedelta(seconds=max_age_seconds)
This matches the pattern used in list_sessions() and other time comparisons
in the same file, ensuring type consistency.
Fixes the error: 'Session suspension on startup failed: ...' seen on gateway restart.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
suspend_recently_active()method ingateway/session.pyfails on gateway startup with:This error appears in logs as:
Root Cause
Introduced in commit
2d328d5c(PR #7536). The method calculatescutoffusingtime.time()which returns a float, then compares it withentry.updated_atwhich is adatetimeobject:Fix
Changed the cutoff calculation to use
_now()andtimedelta, matching the pattern used elsewhere in the file (e.g.,list_sessions()):Verification
datetimeobjects)list_sessions()method (line 928)