fix(cron): avoid false provider failure summaries - #83188
Closed
cation98 wants to merge 1 commit into
Closed
Conversation
alt-glitch
added
type/bug
teknium1
added a commit
that referenced
this pull request
Aug 13, 2026
…composed no_agent gate The cherry-picked tests predate #85508's honest fallback-chain phrasing and each other: assertions pinned the old 'exhausted or unavailable' literal and #83188's no_agent fallback-note behavior, which #77648's mode gate supersedes (no provider classification at all for no_agent jobs). Assert the composed contract instead.
Contributor
|
Merged via PR #85536 (rebase-merge) — your commit was cherry-picked onto current main with your authorship preserved in git log. Your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_agentscript jobsRoot cause
The cron delivery summarizer treated any occurrence of
429as a provider rate limit. A source identifier containing those digits therefore produced a misleading Telegram alert. The same summary also claimed that a model fallback chain had been exhausted even when the job intentionally ran inno_agentmode.User impact
Operators now receive an accurate cron failure summary and are no longer directed toward provider quota troubleshooting for local script or source-snapshot failures.
Validation
scripts/run_tests.sh tests/cron/test_scheduler.py tests/cron/test_cron_no_agent.py -q