Skip to content

fix(desktop): titlebar clusters — macOS Y nudge, 24px targets, 13.9px icons - #83083

Merged
OutThisLife merged 2 commits into
mainfrom
bb/titlebar-controls-y
Aug 10, 2026
Merged

fix(desktop): titlebar clusters — macOS Y nudge, 24px targets, 13.9px icons#83083
OutThisLife merged 2 commits into
mainfrom
bb/titlebar-controls-y

Conversation

@OutThisLife

@OutThisLife OutThisLife commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • macOS-only Y nudge on the left titlebar cluster (calc(var(--spacing) * 0.9)), gated on visible traffic lights; flat on Windows/Linux and macOS fullscreen.
  • 24×24px hit targets and 13.9px Codicons across left, right, and pane clusters. Inline font-size plus an unlayered CSS rule override codicon.css's default 16px glyph.
  • No gap between titlebar buttons — one shared flex shell per cluster; reserved width is N × 24px only.

Test plan

  • macOS: left cluster lines up with traffic lights; DevTools shows 24×24 buttons and ~13.9px icon glyphs
  • macOS fullscreen / Windows / Linux: no Y nudge on the left cluster
  • Left and right clusters: buttons flush, no inter-button gap
  • Overlay close, HUD exit, and artifacts refresh match the same icon sizing

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

running on a843bcc — fix(desktop): sort titlebar import for eslint

waiting for jobs to start…

@OutThisLife OutThisLife changed the title fix(desktop): nudge the left titlebar cluster down ~3px fix(desktop): align left titlebar cluster with macOS traffic lights Aug 10, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Aug 10, 2026
… icons

Left cluster gets a macOS-only translate to sit on the traffic-light row.
All titlebar tools use 24×24 hit areas with 13.9px Codicons (inline size
beats unlayered codicon.css). Clusters share one flex shell with no gap —
buttons abut and the hit target is the spacing.
@OutThisLife
OutThisLife force-pushed the bb/titlebar-controls-y branch from 521edf7 to d1f2e32 Compare August 10, 2026 09:24
@OutThisLife OutThisLife changed the title fix(desktop): align left titlebar cluster with macOS traffic lights fix(desktop): titlebar clusters — macOS Y nudge, 24px targets, 13.9px icons Aug 10, 2026
@OutThisLife
OutThisLife enabled auto-merge August 10, 2026 09:25
@OutThisLife
OutThisLife merged commit 4e46129 into main Aug 10, 2026
36 checks passed
@OutThisLife
OutThisLife deleted the bb/titlebar-controls-y branch August 10, 2026 09:38
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
…ontrols-y

fix(desktop): titlebar clusters — macOS Y nudge, 24px targets, 13.9px icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants