fix(cli): prevent crash in save_config_value when model is a string - #83
Merged
teknium1 merged 1 commit intoFeb 27, 2026
Merged
Conversation
load_cli_config() supports both string and dict formats for the model key (e.g. `model: "anthropic/claude-opus-4"`), but save_config_value() assumed all intermediate keys are dicts. When the config file used the string format, running `/model <name>` would crash with TypeError: 'str' object does not support item assignment. Add an isinstance check so non-dict values are replaced with a fresh dict before descending.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ring-model fix(cli): prevent crash in save_config_value when model is a string
Meraniya
pushed a commit
to Meraniya/hermes-agent
that referenced
this pull request
Aug 6, 2026
…s2vu6e fix(cron): add missing `_contains_gateway_lifecycle_command` to hermes_cli.cron
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_config_value()crashes withTypeErrorwhen the config file uses the string model format (model: "anthropic/claude-opus-4") because it assumes all intermediate keys are dictsisinstance(current[key], dict)check so non-dict values are replaced with a fresh dict before descendingReproduction
~/.hermes/config.yamlto:/model some-other-modelTypeError: 'str' object does not support item assignmentmodel: {default: "some-other-model"}