Skip to content

fix(discord): notify owners on blocking prompts - #82982

Open
doryani-ai wants to merge 1 commit into
NousResearch:mainfrom
doryani-cloud:fix/discord-blocking-prompt-mentions
Open

fix(discord): notify owners on blocking prompts#82982
doryani-ai wants to merge 1 commit into
NousResearch:mainfrom
doryani-cloud:fix/discord-blocking-prompt-mentions

Conversation

@doryani-ai

Copy link
Copy Markdown

Summary

Discord blocking prompts can now opt in to mentioning numeric allowlisted owners, so an agent waiting in a quiet channel or thread produces a native notification instead of silently stalling.

This is a current-main salvage of #47342 by @nanobro. It preserves that PR's four-prompt scope while incorporating the July review feedback: no Discord-only kwargs cross the generic gateway contract, mentions live in the plain content mirror, and delivery uses the existing opt-in discord.approval_mentions mechanism with scoped AllowedMentions.

Changes

  • extend discord.approval_mentions from exec approvals to:
    • slash-command confirmations
    • clarify questions (button and open-ended paths)
    • update prompts
  • keep the setting default-off and mention only numeric entries from discord.allow_from
  • keep role, @everyone, replied-user, and non-owner user pings disabled by
    passing the exact numeric owner objects to Discord's AllowedMentions
  • keep each adapter's opt-in profile-scoped under multiplexing while preserving
    the documented env-over-config precedence in single-profile mode
  • bound large owner mention lists and account for mentions inside Discord's
    2,000-character content budget
  • document the complete setting behavior in the Discord user guide

Validation

  • regression tests were written first and failed on all three missing sibling paths
  • canonical targeted runner: 29 passed across mention, profile-isolation,
    content-budget, content-mirror, clarify, allowed-mentions, approval-content,
    and timeout coverage
  • ruff check passed for the changed Python files
  • static added-line scan found no credential, injection, eval/exec, unsafe deserialization, or SQL-construction findings

Prior art

No issue is closed: the exact existing contribution is #47342.

@alt-glitch alt-glitch added type/feature New feature or request comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins platform/discord Discord bot adapter P3 Low — cosmetic, nice to have sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 10, 2026
Extend the existing opt-in approval mention policy to slash confirmations, clarification questions, and update prompts. Keep mentions profile-scoped under multiplexing and bounded within Discord's content limit.

Co-authored-by: nanobro <38958450+nanobro@users.noreply.github.com>
@doryani-ai
doryani-ai force-pushed the fix/discord-blocking-prompt-mentions branch from 2d05a20 to c18463b Compare August 18, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have platform/discord Discord bot adapter sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants