fix(packaging): ship bundled plugin manifests - #82977
Closed
JoaoMarcos44 wants to merge 1 commit into
Closed
JoaoMarcos44 wants to merge 1 commit into
JoaoMarcos44 wants to merge 1 commit into
Conversation
JoaoMarcos44
marked this pull request as ready for review
August 10, 2026 06:13
Contributor
|
looks mergeable The package-data declaration matches the runtime discovery boundary: every bundled Security evidence:
Not checked:
Signed: GPT-5.6-sol-xhigh in Codex |
This was referenced Aug 15, 2026
Closed
Collaborator
|
Merged via PR #86670. Your commit was cherry-picked onto current main with your authorship preserved in git log — thank you for the fix and the thorough artifact-level regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #82916.
Hermes 2026.8.3 could install bundled plugin Python modules without their runtime manifests. Platform adapters then existed on disk but were invisible to plugin discovery, so Feishu, Discord, Slack, Teams and other platform plugins never registered.
This PR fixes the packaging contract at its source and adds artifact-level regression coverage.
User-visible failure
On the affected installation:
The gateway is not missing a Feishu implementation. It is missing the metadata that tells Hermes to discover and defer-load that implementation.
Root cause
Bundled plugin layout:
Packaging flow before this PR:
Infographic :
The specific metadata gap was in
[tool.setuptools.package-data]:plugins.*was listed for Python package discovery, but nopluginsdata entry covered YAML manifests.This regression appeared when packaging configuration was simplified in #68217. It reintroduced the same packaging failure class previously fixed by #34034 and #28149.
Fix
pyproject.tomlnow declares:This keeps manifest selection beside the package metadata that controls artifact contents. No gateway fallback, adapter duplication, import workaround, or platform-specific branch was added.
Regression protection
tests/test_packaging_build_guard.pynow:plugin.yamlandplugin.ymlunder the sourceplugins/tree.This catches both:
Validation evidence
Pre-fix reproduction
Built from the affected packaging configuration:
The new regression test failed with all bundled manifests reported missing.
Fixed artifacts
A clean extracted-wheel smoke test then executed the real scanner:
Local tests
Ruff passed for changed files.
GitHub CI
PR checks completed successfully:
Scope and non-goals
The fix makes generated artifacts complete for the manifest contract without resurrecting removed distribution-policy paths.
Files changed
pyproject.toml: include bundled plugin manifests in setuptools package data.tests/test_packaging_build_guard.py: verify wheel and sdist contents against the complete source manifest set.Release note
The fix takes effect in artifacts built from the merged commit. Existing 2026.8.3 installations remain broken until upgraded to a release containing this change.
Related: #82916, #34034, #28149, #68217.