Skip to content

Feat clean v3 - #82686

Closed
Synxneuos wants to merge 2 commits into
NousResearch:mainfrom
Synxneuos:feat-clean-v3
Closed

Synxneuos wants to merge 2 commits into
NousResearch:mainfrom
Synxneuos:feat-clean-v3

Conversation

@Synxneuos

Copy link
Copy Markdown

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

- Add nvidia-rag-blueprint skill for NVIDIA RAG systems
- Add nvidia-cuopt-numerical-optimization-api-python skill for GPU-accelerated optimization
- Add nvidia-cudaq-guide skill for CUDA-Q quantum computing onboarding
@alt-glitch alt-glitch added invalid This doesn't seem right P3 Low — cosmetic, nice to have comp/tools Tool registry, model_tools, toolsets labels Aug 9, 2026

@Riccardo-Vecchi Riccardo-Vecchi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a duplicate/retry of #82671, but it is not clean yet: the PR still contains the same 59 files / +4,867 lines, dominated by the unrelated NVIDIA optional-skill tree, and the body is still the untouched template. The intended AST tool is only two of those files.

Please close one of #82671/#82686 to keep a single review thread, create a branch directly from current main, and apply only tools/ast_search.py plus its focused tests. The completed PR body also needs the Cortex source revision and license/provenance for the port, along with the repository test command/results.

@Synxneuos

Copy link
Copy Markdown
Author

Closing this PR as per @teknium1 decision on #82695 regarding AST search tools. Thanks!

@Synxneuos Synxneuos closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets invalid This doesn't seem right P3 Low — cosmetic, nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants