fix: honor network.force_ipv4 on run_agent and legacy cli bootstrap - #82634
Closed
hekwweiss89 wants to merge 1 commit into
Closed
fix: honor network.force_ipv4 on run_agent and legacy cli bootstrap#82634hekwweiss89 wants to merge 1 commit into
hekwweiss89 wants to merge 1 commit into
Conversation
apply_configured_ipv4_preference reads config.yaml (with managed-scope overlay and non-mapping root guards) and patches socket.getaddrinfo so hermes-agent / python cli.py match the hermes CLI workaround for broken IPv6 hangs. Extends regression coverage for config loading and both entry points. Addresses #37662 review feedback on #37818.
alt-glitch
added
type/bug
Author
|
Closing — opened by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_configured_ipv4_preference()to readnetwork.force_ipv4fromconfig.yaml, guard non-mapping YAML roots, and honor managed-scope overlaysrun_agent.pyand legacycli.pybootstrap sohermes-agent/python cli.pymatch thehermesCLI workaround for broken IPv6 hangsContext
network.force_ipv4was already applied inhermes_cli/main.py, gateway, and cron, but not in therun_agent/ legacy CLI entry paths (#37662). This is a salvage of #37818 addressing the review feedback (mapping guard + managed-scope overlay).Testing
scripts/run_tests.sh tests/test_ipv4_preference.py -q→ 13 passedFixes #37662